Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-359: update individual searcher to support selection of fields fro… #41

Merged
merged 3 commits into from
Jan 12, 2024
Merged

CM-359: update individual searcher to support selection of fields fro… #41

merged 3 commits into from
Jan 12, 2024

Conversation

jdolkowski
Copy link
Contributor

@jdolkowski jdolkowski commented Jan 11, 2024 •
edited
Loading

sniedzielski
sniedzielski reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to think if this is a proper way to call to social protection gql endpoint to obtain schema.

src/actions.js Outdated Show resolved Hide resolved
@sniedzielski sniedzielski self-requested a review January 11, 2024 14:25
sniedzielski
sniedzielski reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to think if this is a proper way to call to social protection gql endpoint to obtain schema.

@sniedzielski sniedzielski self-requested a review January 11, 2024 14:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sniedzielski sniedzielski merged commit 1659441 into develop Jan 12, 2024
5 of 6 checks passed
@sniedzielski sniedzielski deleted the feature/CM-359 branch January 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdolkowski @sniedzielski