Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-420: developed new upload flow with validation #45

Merged
merged 32 commits into from
Jan 23, 2024
Merged

Conversation

sniedzielski
Copy link
Contributor

Jan and others added 15 commits December 27, 2023 21:14
validation workflow2

validation workflow2

validation workflow3

validation workflow4

validation workflow5

validation workflow5

validation workflow6

validation workflow7

validation workflow8

validation workflow9

validation workflow9

validation workflow10

validation workflow11

validation workflow12

validation workflow14

validation workflow15

validation workflow16

validation workflow17

validation workflow18

validation workflow19

validation workflow20

validation workflow22

validation workflow23

validation workflow24

validation workflow25

validation workflow26

validation workflow27

validation workflow28

validation workflow29

validation workflow30

validation workflow31

validation workflow32

validation workflow33

validation workflow34

validation workflow35

validation workflow36

validation workflow37

update

CM-420: developed new upload flow with validation
@sniedzielski sniedzielski changed the base branch from feature/CM-378 to develop January 9, 2024 18:12
Copy link
Member

@delcroip delcroip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test for the service (direct or through API)

@sniedzielski sniedzielski requested a review from delcroip January 19, 2024 16:12
Copy link
Contributor

@dborowiecki dborowiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments. Also please add tests in order to enhance coverage and pass quality gateway

social_protection/services.py Outdated Show resolved Hide resolved
social_protection/services.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

47.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sniedzielski
Copy link
Contributor Author

I added some basic test to check if the most important services works without raising any errors. I'll extend those tests later while developing another features.

@dborowiecki dborowiecki merged commit 7dada57 into develop Jan 23, 2024
3 of 7 checks passed
@dborowiecki dborowiecki deleted the CM-420 branch January 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants