-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM-420: developed new upload flow with validation #45
Conversation
validation workflow2 validation workflow2 validation workflow3 validation workflow4 validation workflow5 validation workflow5 validation workflow6 validation workflow7 validation workflow8 validation workflow9 validation workflow9 validation workflow10 validation workflow11 validation workflow12 validation workflow14 validation workflow15 validation workflow16 validation workflow17 validation workflow18 validation workflow19 validation workflow20 validation workflow22 validation workflow23 validation workflow24 validation workflow25 validation workflow26 validation workflow27 validation workflow28 validation workflow29 validation workflow30 validation workflow31 validation workflow32 validation workflow33 validation workflow34 validation workflow35 validation workflow36 validation workflow37 update CM-420: developed new upload flow with validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit test for the service (direct or through API)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments. Also please add tests in order to enhance coverage and pass quality gateway
Quality Gate failedFailed conditions 47.0% Coverage on New Code (required ≥ 80%) |
I added some basic test to check if the most important services works without raising any errors. I'll extend those tests later while developing another features. |
TICKET: https://openimis.atlassian.net/browse/CM-420