Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-381: added validations columns in Individual Data Sources #42

Merged
merged 11 commits into from
Jan 19, 2024

Conversation

sniedzielski
Copy link
Contributor

No description provided.

@sniedzielski sniedzielski marked this pull request as ready for review January 9, 2024 15:15
@delcroip
Copy link
Member

this history GQL will be use everywhere in the long run, can it be done in a form of a mixin between the main table and a generic history mixin

@dborowiecki any thought on that ?

Copy link

@dborowiecki
Copy link
Contributor

@delcroip I think change you've mentioned was moved from this PR and it's not blocking. @sniedzielski could you follow up on this? I'll merge this PR.

@dborowiecki dborowiecki merged commit 47de50e into develop Jan 19, 2024
6 of 12 checks passed
@sniedzielski sniedzielski deleted the feature/CM-381 branch January 19, 2024 17:14
@sniedzielski
Copy link
Contributor Author

sniedzielski commented Jan 19, 2024

Yes, certainly. @delcroip This kind of improvement it's a great idea and I think we can add this one once we'll work on next changelog tasks (for example in programme/benefit plan). 528ab27 + 7f38214. Thanks to this improvement we can add changelog really fast in other modules.
Of course this is only for HistoryModel and HistoryBusinessModel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants