OP-2163: added possibility to configure check for delete operation

[sniedzielski]

TICKET: https://openimis.atlassian.net/browse/OP-2163

• add missing maker-checker logic for deleting group
• make possibility to enable/disable by config - by default maker checker is enabled for Group Deletion

[sniedzielski]

@weilu Could you re-check PR? I added tests as you proposed in your comments.

[weilu]

@sniedzielski Thanks! I simplified the test to be just sufficient to cover the conditional maker-checker logic. I don't think we need to repeat the coverage on Group delete permission.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[lruzicki]

LGTM

[sniedzielski]

Module tests are green, but there is one fail in 'all modules tests':

ERROR: test_other_optionset_sync (dhis2_etl.tests.daily_sync_tests.DailySyncTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/core/validation/base.py", line 62, in validator
    instance.full_clean(validate_unique=False)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/django/db/models/base.py", line 1502, in full_clean
    raise ValidationError(errors)
django.core.exceptions.ValidationError: {'code': ['Ensure this value has at most 6 characters (it has 55).']}

During handling of the above exception, another exception occurred:

@delcroip What should we do with that test? Should we try to fix it before merging this and other PRs?