Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-2301: fixed calculating amounts, fixed displaying CP params #69

Closed
wants to merge 5 commits into from
Closed

OP-2301: fixed calculating amounts, fixed displaying CP params #69

wants to merge 5 commits into from

Conversation

sniedzielski
Copy link
Contributor

@sniedzielski sniedzielski commented Jan 8, 2025 •
edited
Loading

part of ticket https://openimis.atlassian.net/browse/OP-2301
Fixes:

  • fix calculating amount on contract creation and on contract submitting.
  • fix displaying contribution plan parameters while selecting calculation rule
  • fix approving contract
  • fix making contract effective by 'updating' paid amount in payment (insuree/members are taken from CCPD.contract_details.insuree....)

@sniedzielski sniedzielski marked this pull request as ready for review January 8, 2025 14:30
@sniedzielski sniedzielski requested a review from delcroip January 8, 2025 14:30
delcroip
delcroip requested changes Jan 8, 2025
View reviewed changes
calculation/calculation_rule.py Outdated Show resolved Hide resolved
@sniedzielski sniedzielski requested a review from delcroip January 9, 2025 09:41
@sniedzielski
Copy link
Contributor Author

@delcroip Seems that this PR is redundant , we can close it without merging. I checked the whole contract flow from develop and it works as expected.

1 similar comment
@sniedzielski
Copy link
Contributor Author

@delcroip Seems that this PR is redundant , we can close it without merging. I checked the whole contract flow from develop and it works as expected.

@sniedzielski sniedzielski deleted the feature/OP-2301 branch January 9, 2025 09:44
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delcroip delcroip Awaiting requested review from delcroip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sniedzielski @delcroip