Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ZicntrM covergroup #331

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: ZicntrM covergroup #331

wants to merge 1 commit into from

Conversation

coreyqh
Copy link
Contributor

@coreyqh coreyqh commented Nov 21, 2024

  • WIP: missing all coverpoints that are specific to M mode
  • Worked through with Roman, Madeleine, Marina, and Leilani
    • Roman and Madeleine working on ZicntrU
    • Marina and Leilani working on ZicntrS
    • PRs from these teams coming soon, pending review of this general structure and ability to push to github
  • Coverpoints for writing mcounteren/scounteren decoupled from coverpoints for reading corresponding counters
    • Bit swizzling used to create coverpoints for reading counters with their enable bit set
    • Could be recombined using prev and current for back-to-back writes and reads. Open to feedback on whether this is more or less elegant/robust
    • Unsure of whether the walking ones should be filled with zeros or wildcards. For reading counters, it might make more sense not to care about other counters' enables

@coreyqh coreyqh marked this pull request as ready for review November 22, 2024 00:14
@coreyqh
Copy link
Contributor Author

coreyqh commented Nov 25, 2024

All presently implemented coverpoints migrated to ZicntrU and ZicntrS.

@coreyqh coreyqh marked this pull request as draft November 25, 2024 03:02
@davidharrishmc
Copy link
Collaborator

Cp_mcounteren_access_write and cp_scounteren_access_write are missing priv_mode_m in the cross

What are cp_*coutneren_access_read for? I don’t see these in the testplan. Can they be deleted?

I don’t see the coverpoints described in the testplan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants