Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix hpdcache] axi struct usage #1802

Conversation

CoralieAllioux
Copy link
Contributor

Suggested fixes for HDPcache integration in CVA6.
HPDCache is defining again the typedef for AXI protocol, with exactly the sames names than the ones in package ariane_axi. Using Cadence Xcelium simulator, the usage of several typedef with identical names is forbidden.

This fix suggests to propagate the AXI typedef given to cva6 top (through parameter types) to hdpcache. As a consequence, local definition of AXI typedef are removed.

@cfuguet , could you give me your opinion about it?

NB: Feedbacks are welcome, since this is the first PR from Bosch!

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✔️ successful run, report available here.

@JeanRochCoulon
Copy link
Contributor

Hello @CoralieAllioux Happy to see you on GitHub !
Can yuo sign the Eclipse agreement to allow the PR merge

@CoralieAllioux
Copy link
Contributor Author

CoralieAllioux commented Feb 5, 2024

Can yuo sign the Eclipse agreement to allow the PR merge

I already signed the Eclipse agreement.
However, it seems that the Eclipse foundation does not recognize my email: "Author did not have a signed ECA on file. (coralie.allioux@f* DOT bosch DOT com)"
Did you encounter this kind of situation before?

I guess it should be solved now.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✔️ successful run, report available here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@CoralieAllioux CoralieAllioux force-pushed the bugfix/hpdcache_axi_struct_usage branch from 8af43c3 to 7b88198 Compare February 5, 2024 12:03
@JeanRochCoulon JeanRochCoulon requested review from cfuguet and removed request for zarubaf and JeanRochCoulon February 5, 2024 12:09
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Feb 5, 2024

LGTM, we are waiting for @cfuguet approval

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✔️ successful run, report available here.

@cfuguet
Copy link

cfuguet commented Feb 5, 2024

Hello @CoralieAllioux,

Yes, it looks good to me. I do not remember why I redefined those types, but I think that it was because at that moment, all these types were not defined on the CVA6 side.

Thanks !

@JeanRochCoulon JeanRochCoulon merged commit 48ea9a1 into openhwgroup:master Feb 5, 2024
19 checks passed
rohan-10xe pushed a commit to 10x-Engineers/cva6 that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants