-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix hpdcache] axi struct usage #1802
[Bugfix hpdcache] axi struct usage #1802
Conversation
✔️ successful run, report available here. |
Hello @CoralieAllioux Happy to see you on GitHub ! |
I already signed the Eclipse agreement. I guess it should be solved now. |
✔️ successful run, report available here. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
8af43c3
to
7b88198
Compare
LGTM, we are waiting for @cfuguet approval |
✔️ successful run, report available here. |
Hello @CoralieAllioux, Yes, it looks good to me. I do not remember why I redefined those types, but I think that it was because at that moment, all these types were not defined on the CVA6 side. Thanks ! |
Suggested fixes for HDPcache integration in CVA6.
HPDCache is defining again the typedef for AXI protocol, with exactly the sames names than the ones in package ariane_axi. Using Cadence Xcelium simulator, the usage of several typedef with identical names is forbidden.
This fix suggests to propagate the AXI typedef given to cva6 top (through parameter types) to hdpcache. As a consequence, local definition of AXI typedef are removed.
@cfuguet , could you give me your opinion about it?
NB: Feedbacks are welcome, since this is the first PR from Bosch!