refactor(decoder): simplify interrupt indexing #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indexing expression was really complex. It is constant so is is possible to directly use an "unsized" localparam. The values are less than 32 so it is equivalent to previous code. This coding style is the one used in the CSR regfile. It will simplify future modifications, including completing parametrization.
|
❌ failed run, report available here. |
|
Can you rebase your branch to get the up-to-date expected gate count modification ? |
|
6e41bc8 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexing expression was really complex. It is constant so is is
possible to directly use an "unsized" localparam. The values are less
than 32 so it is equivalent to previous code. This coding style is the
one used in the CSR regfile.
It will simplify future modifications, including completing
parametrization.