Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated manifest files #1644

Closed

Conversation

cathales
Copy link
Contributor

Closes #1628

It seems to have been replaced by core/Flist.cva6 and might be outdated.
Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon
Copy link
Contributor

@zarubaf @Jbalkind @niwis Can you confirm these files are not useful ?

@Jbalkind
Copy link
Contributor

We actively use these files please stop trying to delete them

@cathales
Copy link
Contributor Author

@Jbalkind please be more specific about which files you use. Also please take into account issue #1628

@Jbalkind
Copy link
Contributor

We use flist.ariane and ariane.core. I think the other file is used by bender or ESP or something but I don't know. Please stop trying to delete them every few months. Of course these files will be "outdated" because the committers keep accepting PRs which add/remove/move core files without updating these manifest files. By their nature, these files will always be somewhat out of date and need to be updated via PR whenever the downstream project needs to update its submodule pointer to HEAD.

@cathales cathales closed this Nov 20, 2023
@cathales cathales deleted the manifests-cleanup branch November 20, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated manifest files
3 participants