Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement only 1 dcache_ctrl instances when ACC and MMU_PRESENT are disabled #1594

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

JeanRochCoulon
Copy link
Contributor

During ACCELERATE_PORT integration, NumPorts has been upgraded from 3 to 4 in wt_dcache.sv. This has implemented 3 times dcache_ctrl.sv in place of 2 times. @zarubaf Do you confirm/approve ?

During ACCELERATE_PORT integration, NumPorts has been upgraded from 3 to 4 in wt_dcache.sv. This has implemented 3 times dcache_ctrl.sv in place of 2 times.
@zarubaf Do you confirm/approve ?
Copy link
Contributor

github-actions bot commented Nov 3, 2023

❌ failed run, report available here.

@zarubaf
Copy link
Contributor

zarubaf commented Nov 4, 2023

@domenicw can you take a look? I think that was on purpose!

@domenicw
Copy link
Contributor

domenicw commented Nov 4, 2023

Yes, that was on purpose. The third instance is needed for the read access of the accelerator.
I think I see the problem though, the signals are not correctly tied off if the fourth port is unused.
To solve this, I think the loop should stay the same. But the if condition should be changed to not create the additional instance it for the fourth port, if the accelerator is not used. Plus the else block would need to be changed to use the k index instead of just zero.

@JeanRochCoulon JeanRochCoulon changed the title [HOT FIX] Implement only 2 dcache_ctrl instances Implement only 1 dcache_ctrl instances when ACC and MMU_PRESENT are disabled Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

❌ failed run, report available here.

@JeanRochCoulon
Copy link
Contributor Author

Thanks @domenicw for the feedback, I followed your directives. I assume you approve the PR. As soon as it will be green I will merge.

@JeanRochCoulon JeanRochCoulon merged commit b7e936e into master Nov 5, 2023
22 checks passed
@JeanRochCoulon JeanRochCoulon deleted the JeanRochCoulon-patch-3 branch November 5, 2023 22:37
Copy link
Contributor

github-actions bot commented Nov 5, 2023

❌ failed run, report available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants