Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rename Block #1359

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Remove Rename Block #1359

merged 5 commits into from
Sep 11, 2023

Conversation

fatimasaleem
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

❌ failed run, report available here.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

❌ failed run, report available here.

@JeanRochCoulon
Copy link
Contributor

Rename creates a 5% performance increase. Previously rename was done by hardware, by enabling the rename module. From the time we use GCC13, the rename is done by compilation.
Renaming does not work with all configurations. We anticipate collision between renaming and dual issue for instance. @zarubaf can you approve the renaming removal ?

@zarubaf
Copy link
Contributor

zarubaf commented Sep 7, 2023

Thanks for the explanation, that makes sense. Especially if we can do it in GCC. Is this enabled automatically or is there a CPU profile that needs to be picked?

@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Sep 7, 2023 •
edited
Loading

The optimization is enabled by default in GCC (>13). It is not the case with GCC10. @cathales has experienced it on Coremark. Today, we can reach 3.09 Coremark/MHZ

@fatimasaleem fatimasaleem marked this pull request as ready for review September 7, 2023 06:40
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

❌ failed run, report available here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

✔️ successful run, report available here.

@JeanRochCoulon
Copy link
Contributor

Hello @fatimasaleem, I tried to identify the gate count increase source (+300 gates) without success. It is a little bit surprising, we remove RTL while netlist is bigger ?!?!!
I merged anyway.

@JeanRochCoulon JeanRochCoulon merged commit 2b8c7a0 into openhwgroup:master Sep 11, 2023
@fatimasaleem fatimasaleem mentioned this pull request Sep 15, 2023
Closed
@fatimasaleem fatimasaleem deleted the remove-rename branch September 19, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarubaf zarubaf zarubaf approved these changes

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatimasaleem @JeanRochCoulon @zarubaf