spyglass: remove useless assignments (#2439)

openhwgroup · Aug 12, 2024 · af4e374 · af4e374
1 parent 4b51643
commit af4e374
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/core/compressed_decoder.sv b/core/compressed_decoder.sv
@@ -39,7 +39,6 @@ module compressed_decoder #(
   // -------------------
   always_comb begin
     illegal_instr_o  = 1'b0;
-    instr_o          = '0;
     is_compressed_o  = 1'b1;
     instr_o          = instr_i;
     is_macro_instr_o = 0;

diff --git a/core/issue_read_operands.sv b/core/issue_read_operands.sv
@@ -265,7 +265,6 @@ module issue_read_operands
     // CVXIF is always ready to try a new transaction on 1st issue port
     // If a transaction is already pending then we stall until the transaction is done.(issue_ack_o[0] = 0)
     // Since we can not have two CVXIF instruction on 1st issue port, CVXIF is always ready for the pending instruction.
-    fus_busy[0].cvxif = 1'b0;
     if (!flu_ready_i) begin
       fus_busy[0].alu = 1'b1;
       fus_busy[0].ctrl_flow = 1'b1;

diff --git a/core/scoreboard.sv b/core/scoreboard.sv
@@ -166,9 +166,8 @@ module scoreboard #(
 
   // an instruction is ready for issue if we have place in the issue FIFO and it the decoder says it is valid
   always_comb begin
-    decoded_instr_ack_o = '0;
-    issue_instr_o       = decoded_instr_i;
-    orig_instr_o        = orig_instr_i;
+    issue_instr_o = decoded_instr_i;
+    orig_instr_o  = orig_instr_i;
     for (int unsigned i = 0; i < CVA6Cfg.NrIssuePorts; i++) begin
       // make sure we assign the correct trans ID
       issue_instr_o[i].trans_id = issue_pointer[i];

diff --git a/spyglass/reference_summary.rpt b/spyglass/reference_summary.rpt
@@ -3,9 +3,9 @@
 #
 # This file has been generated by SpyGlass:
 #     Report Name      : summary
-#     Report Created by: runner_riscv-public
-#     Report Created on:  Thu Aug  1 11:05:24 2024
-#     Working Directory: /gitlab-runner/runner_riscv-public/builds/yD5zmwgi3/0/riscv-ci/cva6/spyglass
+#     Report Created by: asintzoff
+#     Report Created on:  Mon Aug 12 08:41:26 2024
+#     Working Directory: /home/asintzoff/git-repo/tss/cva6/spyglass
 #     SpyGlass Version : SpyGlass_vS-2021.09-SP2-3
 #     Policy Name      : SpyGlass(SpyGlass_vS-2021.09-SP2-03)
 #                        erc(SpyGlass_vS-2021.09-SP2-03)
@@ -17,9 +17,9 @@
 #                        starc(SpyGlass_vS-2021.09-SP2-03)
 #                        starc2005(SpyGlass_vS-2021.09-SP2-03)
 #
-#     Total Number of Generated Messages :       1526
-#     Number of Waived Messages          :          2
-#     Number of Reported Messages        :       1524
+#     Total Number of Generated Messages :       1517
+#     Number of Waived Messages          :        322
+#     Number of Reported Messages        :       1195
 #     Number of Overlimit Messages       :          0
 #
 #
@@ -113,20 +113,16 @@ WARNING    STARC05-2.2.3.3      14    Do not assign over the same signal in
                                       circuits 
 WARNING    W224                 2     Multi-bit expression found when one-bit 
                                       expression expected 
-WARNING    W240                 319   An input has been declared but is not 
-                                      read 
 WARNING    W263                 4     A case expression width does not match 
                                       case select expression width 
 WARNING    W287b                36    Output port of an instance is not 
                                       connected 
-WARNING    W415a                538   Signal may be multiply assigned (beside 
+WARNING    W415a                535   Signal may be multiply assigned (beside 
                                       initialization) in the same scope. 
 WARNING    W480                 3     Loop index is not of type integer 
 WARNING    W486                 2     Shift overflow - some bits may be lost 
 WARNING    W528                 486   A signal or variable is set but never 
                                       read 
-INFO       W240                 1     An input has been declared but is not 
-                                      read 
 INFO       W528                 1     A signal or variable is set but never 
                                       read 
 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++