Add comments to hvp

openhwgroup · Dec 29, 2023 · 965b960 · 965b960
1 parent 4081861
commit 965b960
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/verif/sim/Makefile b/verif/sim/Makefile
@@ -253,7 +253,7 @@ vcs-uvm:
 	$(tool_path)/spike-dasm --isa=$(variant) < ./vcs_results/default/vcs.d/trace_rvfi_hart_00.dasm > $(log)
 
 generate_cov_dash:
-	urg -hvp_proj cva6_embedded -format both -group instcov_for_score -hvp_attributes description -dir vcs_results/default/vcs.d/simv.vdb -plan cva6.hvp -tgl portsonly
+	urg -hvp_proj cva6_embedded -format both -group instcov_for_score -hvp_attributes weight+description+Comment -dir vcs_results/default/vcs.d/simv.vdb -plan cva6.hvp -tgl portsonly
 
 vcs_clean_all:
 	@echo "[VCS] Cleanup (entire vcs_work dir)"

diff --git a/verif/sim/cva6.hvp b/verif/sim/cva6.hvp
@@ -10,7 +10,10 @@ plan "CVA6 Verification Master Plan";
             description = "Instruction Set Architecture\nSpecification: Done, Dvplan: Done, Verification execution: Done";
             feature RV32I;
                 description = "I extension";
+                Comment = "";
                 feature ADD;
+                    Comment = "Issue in Spike-dasm decoder
+Waiting for ISA_DECODER to be merge on master";
                     measure Group ADD;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32i_add_cg";
                     endmeasure
@@ -66,16 +69,19 @@ plan "CVA6 Verification Master Plan";
                     endmeasure
                 endfeature
                 feature DRET;
+                    Comment = "RVFI limitation issue(#1338)";
                     measure Group DRET;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32i_dret_cg";
                     endmeasure
                 endfeature
                 feature EBREAK;
+                    Comment = "RVFI limitation issue(#1338)";
                     measure Group EBREAK;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32i_ebreak_cg";
                     endmeasure
                 endfeature
                 feature ECALL;
+                    Comment = "RVFI limitation issue(#1338)";
                     measure Group ECALL;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32i_ecall_cg";
                     endmeasure
@@ -332,6 +338,7 @@ plan "CVA6 Verification Master Plan";
                     endmeasure
                 endfeature
                 feature EBREAK;
+                    Comment = "RVFI limitation issue(#1338)";
                     measure Group EBREAK;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32c_ebreak_cg";
                     endmeasure
@@ -462,6 +469,7 @@ plan "CVA6 Verification Master Plan";
             endfeature
             feature RV32ZIFENCEI;
                 description = "ZIFENCE.I extension";
+                Comment = "Issue in Spike-dasm decoder\nWaiting for ISA_DECODER to be merge on master";
                 measure Group FEINCE_I;
                     source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32zifencei_fence_i_cg";
                 endmeasure
@@ -479,6 +487,7 @@ plan "CVA6 Verification Master Plan";
             feature RV32ZCB;
                 weight = 0;
                 description = "ZCB extension";
+                Comment = "Issue in Spike-dasm decoder\nWaiting for ISA_DECODER to be merge on master";
                 measure Group C_MUL;
                 endmeasure
                 measure Group C_ZEXT_B;
@@ -496,6 +505,7 @@ plan "CVA6 Verification Master Plan";
             endfeature
             feature RV32ZB;
                 description = "Bitmanip extension";
+                Comment = "Issue in Spike-dasm decoder\nWaiting for ISA_DECODER to be merge on master";
                 feature RV32ZBA;
                     measure Group SH1ADD;
                         source = "group instance: uvma_isacov_pkg.uvma_isacov_pkg.rv32zba_sh1add_cg";
@@ -616,6 +626,7 @@ plan "CVA6 Verification Master Plan";
         endfeature
         feature "CSR access";
             description = "CSR registers access.\nSpecification: Done, Dvplan: Done, Verification execution: Done";
+            Comment = "Issue in Spike-dasm decoder\nWaiting for ISA_DECODER to be merge on master";
             feature "CSR CODE COVERAGE";
                 measure Line, Cond, Toggle CSR_code_cov;
                     source = "tree: uvmt_cva6_tb.cva6_dut_wrap.cva6_tb_wrapper_i.i_cva6.csr_regfile_i";
@@ -1274,6 +1285,7 @@ plan "CVA6 Verification Master Plan";
         endfeature
         feature TRAPs;
             description = "Interrupts and Exceptions.\nSpecification: Done, Dvplan: Done, Verification execution: No.";
+            Comment = "RVFI limitation issue(#1338)";
             feature Interrupts;
                 measure Group Interrupts;
                 endmeasure
@@ -1290,6 +1302,7 @@ plan "CVA6 Verification Master Plan";
         endfeature
         feature PMP;
             description = "Physical Memory Protection suppor.t\nSpecification: No, Dvplan: No, Verification execution: No.";
+            Comment = "Need to separate PMP from MMU";
             measure Group PMP;
             endmeasure
         endfeature