Axi Back to Back example with good headers #2559

khandelwaltanuj · 2024-11-21T13:37:44Z

There is a new PR, I have done a lot cleaning in this one.
This contain an example of an AXI connected back to back. Master agent is connected to slave agent.

I have removed many unsed files (19 now from 42 files to merge). I have added header everywhere except in do files.
I have not move do files yet.

thanks and regards
Tanuj Khandelwal

In this example a master AXI agent is connected to a slave AXI agent.

lib/cv_dv_utils/python/sim_cmd/README.md

MikeOpenHWGroup

Hi @khandelwaltanuj, thanks for fixing the licenses. I made a comment on sim_cmd/compile.py about adding a new copyright to an existing copyright. The guidance I have received on this is:

If an open-source file already has a copyright header, you are not required to change it.
You may add your own copyright header if you have modified the original.

So, if you have made modifications to the files in this PR that already have a copyright header, that is OK. Can you add a reply to my comment on sim_cmd/compile.py?

lib/cv_dv_utils/python/sim_cmd/compile.py

khandelwaltanuj · 2024-11-21T14:48:12Z

Hi @MikeOpenHWGroup

For infomation: Each file comitted with this PR are new files which did not exists before in the github.

Regards
tanuj khandelwal

khandelwaltanuj · 2024-11-21T15:30:49Z

Hi @MikeOpenHWGroup

I have removed now all references to varilab copyright.

Regarsd
Tanuj

MikeOpenHWGroup

Thanks @khandelwaltanuj!

MikeOpenHWGroup · 2024-11-21T16:03:04Z

Hi @ASintzoff, I am 99% confident that this pull-request will not impact CVA6 in any way because it is all new files that are not used in the CVA6 UVM environment. However, I have been wrong before, so if you could also have a look that would be helpful. Thanks.

ASintzoff

Is it possible to squash all "update header" commits to avoid such kind of commits in github.com/openhwgroup/core-v-verif repository?

ASintzoff · 2024-11-22T07:39:55Z

lib/cv_dv_utils/python/sim_cmd/README.md

@@ -0,0 +1,12 @@
+# SIM CMD
+## Introduction
+These are pyhton scripts, they allow to compile and run a test. 


Suggested change

These are pyhton scripts, they allow to compile and run a test.

These are python scripts, they allow to compile and run a test.

ASintzoff · 2024-11-22T07:40:18Z

lib/cv_dv_utils/python/sim_cmd/README.md

+To run a test 
+python3 run_test.py --yaml simulator_vcs.yaml --test_name bursty_test_c
+
+The templates of yaml files are providede with the script, which can be used to copile and run the test


Suggested change

The templates of yaml files are providede with the script, which can be used to copile and run the test

The templates of yaml files are provided with the script, which can be used to compile and run the test

ASintzoff · 2024-11-22T07:41:22Z

lib/uvm_agents/uvma_axi5/example/README.md

@@ -0,0 +1,16 @@
+# AXI master to slave example
+## Introduction
+In this example, an axi master agent is connected to axi slave agent. This example alows a fast verification of changes made in the AXI agent. 


Suggested change

In this example, an axi master agent is connected to axi slave agent. This example alows a fast verification of changes made in the AXI agent.

In this example, an AXI master agent is connected to AXI slave agent. This example allows a fast verification of changes made in the AXI agent.

ASintzoff · 2024-11-22T08:06:02Z

lib/uvm_agents/uvma_axi5/example/sv/dut_env_axi_ohg.sv

+    //  master_cfg.set_is_reactive(1'b0);
+      master_cfg.set_id_management_enable(1'b0);
+     // master_cfg.set_protocol_checker_enable(1'b1);
+     // master_cfg.set_covergroup_enable(1'b1);
+     // master.set_agent_config(master_cfg);


any reason to keep the commented lines?

ASintzoff · 2024-11-22T08:06:16Z

lib/uvm_agents/uvma_axi5/example/sv/dut_env_axi_ohg.sv

+    //  slave_cfg.set_is_reactive(1'b1);
+      slave_cfg.set_id_management_enable(1'b0);
+     // slave_cfg.set_protocol_checker_enable(1'b0);
+     // slave_cfg.set_covergroup_enable(1'b0);
+     // slave.set_agent_config(slave_cfg);


any reason to keep the commented lines?

khandelwaltanuj · 2024-11-22T08:32:42Z

Hi @ASintzoff

Thanks for the review. I have cleaned the README and removed the commencted lines.
Though I have not idea on how to squash the multiple "header update" into one as they all concern different files and I made the changes using github editor.

Thanks and regards
Tanuj Khandelwal

MikeOpenHWGroup · 2024-11-22T13:05:01Z

I have not idea on how to squash the multiple "header update" into one

This is a very useful 'git' skill! Here are two ways to do it:

1 using the git command-line.
2 using the Github Desktop.

khandelwaltanuj · 2024-11-25T08:55:00Z

Hi @MikeOpenHWGroup

I have squashed the commits.
Thanks and Regards
Tanuj Khandelwal

MikeOpenHWGroup · 2024-11-25T12:55:12Z

Thanks @khandelwaltanuj.

Hi @ASintzoff, pls have another look.

ASintzoff · 2024-11-26T14:03:07Z

I'm still puzzled by some commits (header updates). BTW, it will be better to not modify legal stuff if it can be the correct one in the first commit.

updated headers, removed unused files updated headers squashing multiple commits to one updated headers Update compile.py updated header updated header updated header updated header updated header updated header updated header updated header updated header updated header updated header updated header updated header updated header Update README.md Corrected errors in README Update README.md Corrected read and added an header Update README.md Added an header Update dut_env.sv Remove the commented lines Update dut_env_axi_ohg.sv Removed commented lines [uvma_axi verif] change mem default to random from X

khandelwaltanuj · 2024-11-26T14:36:24Z

Hi

I have made another attempt at squashing some more header update commits.

Regards
Tanuj

khandelwaltanuj · 2024-12-06T10:16:13Z

Hello,

Can we merge this one ?

Regards
Tanuj

khandelwaltanuj added 2 commits November 21, 2024 14:06

Added a back to back axi exmaple and scripts to compile it.

15bb208

In this example a master AXI agent is connected to a slave AXI agent.

updated headers, removed unused files

6c61ff4

MikeOpenHWGroup reviewed Nov 21, 2024

View reviewed changes

lib/cv_dv_utils/python/sim_cmd/README.md Show resolved Hide resolved

MikeOpenHWGroup reviewed Nov 21, 2024

View reviewed changes

lib/cv_dv_utils/python/sim_cmd/compile.py Show resolved Hide resolved

MikeOpenHWGroup approved these changes Nov 21, 2024

View reviewed changes

MikeOpenHWGroup requested a review from ASintzoff November 21, 2024 16:01

ASintzoff reviewed Nov 22, 2024

View reviewed changes

khandelwaltanuj force-pushed the origin branch from c89bcd2 to 1d332a6 Compare November 25, 2024 08:53

khandelwaltanuj force-pushed the origin branch from 1d332a6 to d456430 Compare November 26, 2024 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Axi Back to Back example with good headers #2559

Axi Back to Back example with good headers #2559

khandelwaltanuj commented Nov 21, 2024

MikeOpenHWGroup left a comment

khandelwaltanuj commented Nov 21, 2024

khandelwaltanuj commented Nov 21, 2024

MikeOpenHWGroup left a comment

MikeOpenHWGroup commented Nov 21, 2024

ASintzoff left a comment

ASintzoff Nov 22, 2024

ASintzoff Nov 22, 2024

ASintzoff Nov 22, 2024

ASintzoff Nov 22, 2024

ASintzoff Nov 22, 2024

khandelwaltanuj commented Nov 22, 2024

MikeOpenHWGroup commented Nov 22, 2024

khandelwaltanuj commented Nov 25, 2024

MikeOpenHWGroup commented Nov 25, 2024

ASintzoff commented Nov 26, 2024

khandelwaltanuj commented Nov 26, 2024

khandelwaltanuj commented Dec 6, 2024

	These are pyhton scripts, they allow to compile and run a test.
	These are python scripts, they allow to compile and run a test.

	The templates of yaml files are providede with the script, which can be used to copile and run the test
	The templates of yaml files are provided with the script, which can be used to compile and run the test

	In this example, an axi master agent is connected to axi slave agent. This example alows a fast verification of changes made in the AXI agent.
	In this example, an AXI master agent is connected to AXI slave agent. This example allows a fast verification of changes made in the AXI agent.

Axi Back to Back example with good headers #2559

Are you sure you want to change the base?

Axi Back to Back example with good headers #2559

Conversation

khandelwaltanuj commented Nov 21, 2024

MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

khandelwaltanuj commented Nov 21, 2024

khandelwaltanuj commented Nov 21, 2024

MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

MikeOpenHWGroup commented Nov 21, 2024

ASintzoff left a comment

Choose a reason for hiding this comment

ASintzoff Nov 22, 2024

Choose a reason for hiding this comment

ASintzoff Nov 22, 2024

Choose a reason for hiding this comment

ASintzoff Nov 22, 2024

Choose a reason for hiding this comment

ASintzoff Nov 22, 2024

Choose a reason for hiding this comment

ASintzoff Nov 22, 2024

Choose a reason for hiding this comment

khandelwaltanuj commented Nov 22, 2024

MikeOpenHWGroup commented Nov 22, 2024

khandelwaltanuj commented Nov 25, 2024

MikeOpenHWGroup commented Nov 25, 2024

ASintzoff commented Nov 26, 2024

khandelwaltanuj commented Nov 26, 2024

khandelwaltanuj commented Dec 6, 2024