Update openHAB.sh for more reliable restarts. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make openHAB restart more reliably. -the old -d check for JAVA_HOME doesn't always work if directory is a link, use -e instead. -actual path to instance.properties file changed it seems, karaf was dropped from pathname. -removes instance.properties file if process really down after a stop.
|
Looks good to me. Additionally, it sounds to me like you are experienced. |
|
After some path are changed, this has to be adapted. rm ${QPKG_DISTRIBUTION}/userdata/tmp/instances/instance.properties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make openHAB restart more reliably.
I found under Qnap 4.3.4 there were 2 reasons that openHAB 2.0.0 won't start.
First reason would show up in logs as: "Java not found! Please read the documentation about details."
Second reason was issues with instance.properties file was both looked for in wrong path, and also not being removed. 3 changes were made:
Attempts to fix #31 #46 #47