Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rules] Rule Builder: Add DateTime & TimeOfDay triggers & Improve type defs #291

Merged
merged 10 commits into from
Sep 4, 2023
Merged

[rules] Rule Builder: Add DateTime & TimeOfDay triggers & Improve type defs #291

merged 10 commits into from
Sep 4, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05
[rules] Improve Rule Builder type defs
6f35814 
Closes openhab#217.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Regenerate type defs
e5f407b 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[triggers] Minor JSDoc improvements
391a4be 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[rules] Add DateTime and TimeOfDay triggers to Rule Builder
e09dd44 
Closes openhab#280.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Regenerate types
114db0a 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[triggers] Add debug logging
d4624f7 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[rules] Fix wrong, add missing and reformat JSDoc for trigger builder
a66410a 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Regenerate type defs
c35f260 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner August 13, 2023 13:07
@florian-h05
Update README
0ead76e 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 mentioned this pull request Aug 13, 2023
Closed
@florian-h05 florian-h05 added the enhancement New feature or request label Aug 13, 2023
@florian-h05 florian-h05 added this to the to be released milestone Aug 13, 2023
@jlaur jlaur mentioned this pull request Aug 23, 2023
Closed
@florian-h05
Copy link
Contributor Author

@digitaldan Can you please review this one? Thanks.

digitaldan
digitaldan approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-h05 florian-h05 merged commit 07ad540 into openhab:main Sep 4, 2023
4 checks passed
@florian-h05 florian-h05 deleted the rule-builder branch September 4, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitaldan digitaldan digitaldan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Rule Builder API doesn’t support the DateTimeTrigger [rules] Improve type defs for rule builder
2 participants
@florian-h05 @digitaldan