Improve errors when an item no longer exists #354
Draft
+395
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccutrer
force-pushed
the
stale-proxies
branch
from
0ba2f00
to
083faf4
Compare
|
How does it behave when referring to an item that had never existed in the first place? |
Enumerable and predicate methods will now behave better when they refer to stale proxies - filtering methods will just remove them. I run into this occasionally when I have multiple rules firing, and some of them are adding or removing items - and calling items.locations would raise a NoMethodError for #location? due to a race condition. This should no longer happen - it will just ignore the now-stale items. Signed-off-by: Cody Cutrer <[email protected]>
If a user keeps a ref to an item, and that item disappears, calling a method on that item will now raise a helpful StaleProxyError, instead of a NoMethodError on nil The proxy code was significantly refactored, and Thing proxies will also inherit the same stale proxy handling. I also removed the $things registry lookup on every access of a thing, using the same event subscriber mechanism as Item. I also moved several methods from GenericItem to Item, so that Proxy can detect that those methods should exist even for dummy/stale items. Signed-off-by: Cody Cutrer <[email protected]>
ccutrer
force-pushed
the
stale-proxies
branch
from
083faf4
to
9acceb6
Compare
|
Exactly as before - it depends on the context. If it's a context that we're expecting an item (and thus dummy item creation is enabled), it will just create the item proxy, even though an item doesn't exist. In other contexts, it will still raise an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user keeps a ref to an item, and that item disappears, calling a method on that item will now raise a helpful StaleProxyError, instead of a NoMethodError on nil
The proxy code was significantly refactored, and Thing will also inherit the same stale proxy I also removed the $things registry lookup on every access of a thing, using the same event subscriber mechanism as Item.
I also moved several methods from GenericItem to Item, so that Proxy can detect that those methods should exist even for dummy/stale items.