fix mired detection in OH 4.3

the default unit for it changed, and aliases were added, so we need to make sure to parse it first, and then compare against the actual constant for it Signed-off-by: Cody Cutrer <[email protected]>
openhab · Nov 25, 2024 · 42a382d · 42a382d
1 parent 2cf93a7
commit 42a382d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/openhab/dsl/items/builder.rb b/lib/openhab/dsl/items/builder.rb
@@ -582,9 +582,9 @@ def expire(*args, command: nil, state: nil, ignore_state_updates: nil, ignore_co
         def unit=(unit)
           @unit = unit
 
-          self.dimension ||= "Temperature" if unit&.to_s == "mired"
-          self.dimension ||= unit && org.openhab.core.types.util.UnitUtils.parse_unit(unit)&.then do |u|
-            org.openhab.core.types.util.UnitUtils.get_dimension_name(u)
+          if (openhab_unit = unit && org.openhab.core.types.util.UnitUtils.parse_unit(unit))
+            self.dimension ||= "Temperature" if openhab_unit == Units::MIRED
+            self.dimension ||= org.openhab.core.types.util.UnitUtils.get_dimension_name(openhab_unit)
           end
           self.format ||= unit && (if Gem::Version.new(Core::VERSION) >= Gem::Version.new("4.0.0.M3")
                                      "%s %unit%"