Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitemap] New optional icon in mappings #2148

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Nov 4, 2023

Related to openhab/openhab-core#3809

Signed-off-by: Laurent Garnier [email protected]

Copy link

netlify bot commented Nov 4, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit cf1d07a
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/654659058b76bb00086d0984
😎 Deploy Preview https://deploy-preview-2148--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Nov 5, 2023
@lolodomo
Copy link
Contributor Author

@stefan-hoehn : you forgot to merge this one ?

@stefan-hoehn stefan-hoehn merged commit e892dc5 into openhab:main Nov 18, 2023
4 checks passed
@stefan-hoehn
Copy link
Contributor

Yes, sorry, done

@lolodomo lolodomo deleted the sitemap_mapping_icon branch November 18, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants