[mail] Ensure SMTP thing status reflects connection status #17817
+95
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <[email protected]>
clinique
added
the
enhancement
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
J-N-K
reviewed
Nov 28, 2024
| /** | ||
| * use this server to send a mail | ||
| * | ||
| * @param mail the Email that needs to be sent | ||
| * @return true if successful, false if failed | ||
| */ | ||
| public boolean sendMail(Email mail) { | ||
| Session localSession = session; |
There was a problem hiding this comment.
If you do it like this a single failed login (or connection problem) during initialization leads to an "forever unable to send mail" state. I don't think that's really a good idea.
There was a problem hiding this comment.
@J-N-K : you're correct. Changed.
…to open the connection if it was not opened. Signed-off-by: Gaël L'hopital <[email protected]>
clinique
changed the title
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique - please see #12972 (comment). 🙂 This will ensure that the issue gets linked and closed upon completing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split session initialization from mail sending
Resolves #17337