Normalize thread names

bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/googletv/GoogleTVConnectionManager.java

@@ -579,15 +579,17 @@ public void connect() {
                 logger.trace("{} - Starting Reader Thread for {}:{}", handler.getThingID(), config.ipAddress,
                         config.googletvPort);
 
-                Thread readerThread = new Thread(this::readerThreadJob, "GoogleTV reader " + handler.getThingID());
+                Thread readerThread = new Thread(this::readerThreadJob,
+                        "OH-binding-" + handler.getThingUID() + "-GoogleTVReader");
                 readerThread.setDaemon(true);
                 readerThread.start();
                 this.readerThread = readerThread;
 
                 logger.trace("{} - Starting Sender Thread for {}:{}", handler.getThingID(), config.ipAddress,
                         config.googletvPort);
 
-                Thread senderThread = new Thread(this::senderThreadJob, "GoogleTV sender " + handler.getThingID());
+                Thread senderThread = new Thread(this::senderThreadJob,
+                        "OH-binding-" + handler.getThingUID() + "-GoogleTVSender");
                 senderThread.setDaemon(true);
                 senderThread.start();
                 this.senderThread = senderThread;
@@ -698,12 +700,14 @@ public void shimInitialize() {
                         this.shimServerSocket = serverSocket;
                         this.shimQueue.clear();
 
-                        Thread readerThread = new Thread(this::shimReaderThreadJob, "GoogleTV shim reader");
+                        Thread readerThread = new Thread(this::shimReaderThreadJob,
+                                "OH-binding-" + handler.getThingUID() + "-GoogleTVShimReader");
                         readerThread.setDaemon(true);
                         readerThread.start();
                         this.shimReaderThread = readerThread;
 
-                        Thread senderThread = new Thread(this::shimSenderThreadJob, "GoogleTV shim sender");
+                        Thread senderThread = new Thread(this::shimSenderThreadJob,
+                                "OH-binding-" + handler.getThingUID() + "-GoogleTVShimSender");
                         senderThread.setDaemon(true);
                         senderThread.start();
                         this.shimSenderThread = senderThread;

bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/shieldtv/ShieldTVConnectionManager.java

@@ -443,12 +443,14 @@ public void connect() {
 
                 setStatus(false, "offline.initializing");
 
-                Thread readerThread = new Thread(this::readerThreadJob, "ShieldTV reader " + handler.getThingID());
+                Thread readerThread = new Thread(this::readerThreadJob,
+                        "OH-binding-" + handler.getThingUID() + "-ShieldTVReader");
                 readerThread.setDaemon(true);
                 readerThread.start();
                 this.readerThread = readerThread;
 
-                Thread senderThread = new Thread(this::senderThreadJob, "ShieldTV sender " + handler.getThingID());
+                Thread senderThread = new Thread(this::senderThreadJob,
+                        "OH-binding-" + handler.getThingUID() + "-ShieldTVSender");
                 senderThread.setDaemon(true);
                 senderThread.start();
                 this.senderThread = senderThread;
@@ -513,13 +515,13 @@ public void shimInitialize() {
                     this.shimServerSocket = serverSocket;
 
                     Thread readerThread = new Thread(this::shimReaderThreadJob,
-                            "ShieldTV shim reader " + handler.getThingID());
+                            "OH-binding-" + handler.getThingUID() + "-ShieldTVShimReader");
                     readerThread.setDaemon(true);
                     readerThread.start();
                     this.shimReaderThread = readerThread;
 
                     Thread senderThread = new Thread(this::shimSenderThreadJob,
-                            "ShieldTV shim sender" + handler.getThingID());
+                            "OH-binding-" + handler.getThingUID() + "-ShieldTVShimSender");
                     senderThread.setDaemon(true);
                     senderThread.start();
                     this.shimSenderThread = senderThread;

bundles/org.openhab.binding.anthem/src/main/java/org/openhab/binding/anthem/internal/handler/AnthemHandler.java

@@ -242,12 +242,12 @@ private synchronized void connect() {
             scheduleConnectRetry(reconnectIntervalMinutes);
             return;
         }
-        Thread localReaderThread = new Thread(this::readerThreadJob, "Anthem reader");
+        Thread localReaderThread = new Thread(this::readerThreadJob, "OH-binding-" + getThing().getUID() + "-Reader");
         localReaderThread.setDaemon(true);
         localReaderThread.start();
         this.readerThread = localReaderThread;
 
-        Thread localSenderThread = new Thread(this::senderThreadJob, "Anthem sender");
+        Thread localSenderThread = new Thread(this::senderThreadJob, "OH-binding-" + getThing().getUID() + "-Sender");
         localSenderThread.setDaemon(true);
         localSenderThread.start();
         this.senderThread = localSenderThread;

bundles/org.openhab.binding.argoclima/src/main/java/org/openhab/binding/argoclima/internal/device/passthrough/RemoteArgoApiServerStub.java

@@ -290,7 +290,7 @@ public synchronized void start() throws ArgoRemoteServerStubStartupException {
                 // to stop, actually)
                 s.setStopTimeout(1000L);
                 try {
-                    new Thread() {
+                    new Thread("OH-binding-" + this.id + "-APIStub") {
                         @Override
                         public void run() {
                             try {

bundles/org.openhab.binding.echonetlite/src/main/java/org/openhab/binding/echonetlite/internal/EchonetLiteBridgeHandler.java

@@ -52,7 +52,8 @@ public class EchonetLiteBridgeHandler extends BaseBridgeHandler {
     private final ArrayBlockingQueue<Message> requests = new ArrayBlockingQueue<>(1024);
     private final Map<InstanceKey, EchonetObject> devicesByKey = new HashMap<>();
     private final EchonetMessageBuilder messageBuilder = new EchonetMessageBuilder();
-    private final Thread networkingThread = new Thread(this::poll);
+    private final Thread networkingThread = new Thread(this::poll,
+            "OH-binding-" + EchonetLiteBindingConstants.BINDING_ID);
     private final EchonetMessage echonetMessage = new EchonetMessage();
     private final MonotonicClock clock = new MonotonicClock();
 
@@ -76,8 +77,6 @@ private void start(final InstanceKey managementControllerKey, InstanceKey discov
         logger.debug("Binding echonet channel");
         echonetChannel = new EchonetChannel(discoveryKey.address);
         logger.debug("Starting networking thread");
-
-        networkingThread.setName("OH-binding-" + EchonetLiteBindingConstants.BINDING_ID);
         networkingThread.setDaemon(true);
         networkingThread.start();
     }

bundles/org.openhab.binding.ekey/src/main/java/org/openhab/binding/ekey/internal/api/EkeyUdpPacketReceiver.java

@@ -48,10 +48,10 @@ public class EkeyUdpPacketReceiver {
 
     private boolean connected = false;
 
-    public EkeyUdpPacketReceiver(final String ipAddress, final int port, final String readerThreadName) {
+    public EkeyUdpPacketReceiver(final String ipAddress, final int port, final String thingUID) {
         this.ipAddress = ipAddress;
         this.port = port;
-        this.readerThreadName = readerThreadName;
+        this.readerThreadName = "OH-binding-" + thingUID;
     }
 
     public void openConnection() throws IOException {

bundles/org.openhab.binding.ekey/src/main/java/org/openhab/binding/ekey/internal/handler/EkeyHandler.java

@@ -82,10 +82,10 @@ public void initialize() {
 
             scheduler.submit(() -> {
                 populateChannels(config.protocol);
-                String readerThreadName = "OH-binding-" + getThing().getUID().getAsString();
 
                 EkeyUdpPacketReceiver localReceiver = receiver = new EkeyUdpPacketReceiver(
-                        Objects.requireNonNullElse(config.natIp, config.ipAddress), config.port, readerThreadName);
+                        Objects.requireNonNullElse(config.natIp, config.ipAddress), config.port,
+                        getThing().getUID().getAsString());
                 localReceiver.addEkeyPacketListener(this);
                 try {
                     localReceiver.openConnection();

bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java

@@ -70,6 +70,7 @@
 import org.eclipse.jetty.util.Callback;
 import org.eclipse.jetty.util.Promise.Completable;
 import org.eclipse.jetty.util.ssl.SslContextFactory;
+import org.openhab.binding.hue.internal.HueBindingConstants;
 import org.openhab.binding.hue.internal.api.dto.clip1.CreateUserRequest;
 import org.openhab.binding.hue.internal.api.dto.clip1.SuccessResponse;
 import org.openhab.binding.hue.internal.api.dto.clip2.BridgeConfig;
@@ -397,7 +398,8 @@ public void onFailure(@Nullable Session session, @Nullable Throwable failure) {
         public void onGoAway(@Nullable Session session, @Nullable GoAwayFrame frame) {
             Objects.requireNonNull(session);
             if (session.equals(http2Session)) {
-                Thread recreateThread = new Thread(() -> recreateSession());
+                Thread recreateThread = new Thread(() -> recreateSession(),
+                        "OH-binding-" + HueBindingConstants.BINDING_ID + "-Clip2Bridge");
                 Clip2Bridge.this.recreateThread = recreateThread;
                 recreateThread.start();
             }

bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/transport/LegacyPort.java

@@ -22,6 +22,7 @@
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.eclipse.jdt.annotation.Nullable;
+import org.openhab.binding.insteon.internal.InsteonBindingConstants;
 import org.openhab.binding.insteon.internal.InsteonLegacyBindingConstants;
 import org.openhab.binding.insteon.internal.config.InsteonLegacyNetworkConfiguration;
 import org.openhab.binding.insteon.internal.device.InsteonAddress;
@@ -178,9 +179,9 @@ public void start() {
         }
 
         readThread = new Thread(reader);
-        setParamsAndStart(readThread, "Reader");
+        setParamsAndStart(readThread, "OH-binding-" + InsteonBindingConstants.BINDING_ID + "-LegacyReader");
         writeThread = new Thread(writer);
-        setParamsAndStart(writeThread, "Writer");
+        setParamsAndStart(writeThread, "OH-binding-" + InsteonBindingConstants.BINDING_ID + "-LegacyWriter");
 
         if (!mdbb.isComplete()) {
             modem.initialize();

bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

@@ -52,10 +52,10 @@ public class IntesisBoxSocketApi {
 
     private boolean connected = false;
 
-    public IntesisBoxSocketApi(final String ipAddress, final int port, final String readerThreadName) {
+    public IntesisBoxSocketApi(final String ipAddress, final int port, final String thingUID) {
         this.ipAddress = ipAddress;
         this.port = port;
-        this.readerThreadName = readerThreadName;
+        this.readerThreadName = "OH-binding-" + thingUID;
     }
 
     private class IntesisSocket {

bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

@@ -93,11 +93,8 @@ public void initialize() {
         if (!config.ipAddress.isEmpty()) {
             updateStatus(ThingStatus.UNKNOWN);
             scheduler.submit(() -> {
-
-                String readerThreadName = "OH-binding-" + getThing().getUID().getAsString();
-
                 IntesisBoxSocketApi intesisLocalApi = intesisBoxSocketApi = new IntesisBoxSocketApi(config.ipAddress,
-                        config.port, readerThreadName);
+                        config.port, getThing().getUID().getAsString());
                 intesisLocalApi.addIntesisBoxChangeListener(this);
                 try {
                     intesisLocalApi.openConnection();

bundles/org.openhab.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactTransceiver.java

@@ -32,6 +32,7 @@
 import java.util.Set;
 import java.util.concurrent.locks.ReentrantLock;
 
+import org.openhab.binding.keba.internal.KebaBindingConstants;
 import org.openhab.core.thing.ThingStatus;
 import org.openhab.core.thing.ThingStatusDetail;
 import org.slf4j.Logger;
@@ -71,7 +72,8 @@ public void start() {
                 selector = Selector.open();
 
                 if (transceiverThread == null) {
-                    transceiverThread = new Thread(transceiverRunnable, "OH-binding-Keba-Transceiver");
+                    transceiverThread = new Thread(transceiverRunnable,
+                            "OH-binding-" + KebaBindingConstants.BINDING_ID + "-Transceiver");
                     transceiverThread.start();
                 }
 

bundles/org.openhab.binding.loxone/src/main/java/org/openhab/binding/loxone/internal/security/LxWsSecurity.java

@@ -86,7 +86,7 @@ public void authenticate(BiConsumer<LxErrorCode, String> doneCallback) {
                 authenticationLock.unlock();
             }
         };
-        new Thread(init).start();
+        new Thread(init, "OH-binding-" + thingHandler.getThingId() + "-Authenticate").start();
     }
 
     /**

bundles/org.openhab.binding.lutron/src/main/java/org/openhab/binding/lutron/internal/handler/IPBridgeHandler.java

@@ -216,7 +216,8 @@ private synchronized void connect() {
         sendCommand(new LIPCommand(TargetType.BRIDGE, LutronOperation.QUERY, LutronCommandType.SYSTEM, null,
                 SYSTEM_DBEXPORTDATETIME));
 
-        messageSender = new Thread(this::sendCommandsThread, "Lutron sender");
+        messageSender = new Thread(this::sendCommandsThread,
+                "OH-binding-" + getBridge().getBridgeUID() + "-IPBridgeSender");
         messageSender.start();
 
         logger.debug("Starting keepAlive job with interval {}", heartbeatInterval);

bundles/org.openhab.binding.lutron/src/main/java/org/openhab/binding/lutron/internal/handler/LeapBridgeHandler.java

@@ -304,12 +304,14 @@ private synchronized void connect() {
 
         updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.NONE, STATUS_INITIALIZING);
 
-        Thread readerThread = new Thread(this::readerThreadJob, "Lutron reader");
+        Thread readerThread = new Thread(this::readerThreadJob,
+                "OH-binding-" + getBridge().getBridgeUID() + "-BridgeReader");
         readerThread.setDaemon(true);
         readerThread.start();
         this.readerThread = readerThread;
 
-        Thread senderThread = new Thread(this::senderThreadJob, "Lutron sender");
+        Thread senderThread = new Thread(this::senderThreadJob,
+                "OH-binding-" + getBridge().getBridgeUID() + "-BridgeSender");
         senderThread.setDaemon(true);
         senderThread.start();
         this.senderThread = senderThread;

bundles/org.openhab.binding.luxom/src/main/java/org/openhab/binding/luxom/internal/handler/LuxomBridgeHandler.java

@@ -139,7 +139,7 @@
 
         updateStatus(ThingStatus.ONLINE);
 
-        messageSender = new Thread(this::sendCommandsThread, "Luxom sender");
+        messageSender = new Thread(this::sendCommandsThread, "OH-binding-" + getBridgeUID() + "-Sender");
         messageSender.start();
 
         logger.debug("Starting heartbeat job with interval {} (seconds)", HEARTBEAT_INTERVAL_SECONDS);

bundles/org.openhab.binding.max/src/main/java/org/openhab/binding/max/internal/handler/MaxCubeBridgeHandler.java

@@ -340,7 +340,8 @@ private synchronized void startAutomaticRefresh() {
             pollingJob = scheduler.scheduleWithFixedDelay(this::refreshData, 0, refreshInterval, TimeUnit.SECONDS);
         }
         if (queueConsumerThread == null || !queueConsumerThread.isAlive()) {
-            queueConsumerThread = new Thread(new QueueConsumer(commandQueue), "max-queue-consumer");
+            queueConsumerThread = new Thread(new QueueConsumer(commandQueue),
+                    "OH-binding-" + getBridge().getBridgeUID() + "-max-queue-consumer");
             queueConsumerThread.setDaemon(true);
             queueConsumerThread.start();
         }

bundles/org.openhab.binding.mihome/src/main/java/org/openhab/binding/mihome/internal/socket/XiaomiSocket.java

@@ -71,7 +71,7 @@ public XiaomiSocket(String owner) {
      */
     public XiaomiSocket(int port, String owner) {
         this.port = port;
-        socketReceiveThread.setName("XiaomiSocketReceiveThread(" + port + ", " + owner + ")");
+        socketReceiveThread.setName("OH-binding-" + this.getThing().getUID() + "-XiaomiSocket(" + port + ", " + owner + ")");
     }
 
     public void initialize() {

bundles/org.openhab.binding.milight/src/main/java/org/openhab/binding/milight/internal/protocol/MilightV6SessionManager.java

@@ -32,6 +32,7 @@
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.eclipse.jdt.annotation.Nullable;
+import org.openhab.binding.milight.internal.MilightBindingConstants;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -185,7 +186,7 @@ public MilightV6SessionManager(String bridgeId, ISessionState observer, @Nullabl
             throw new IllegalArgumentException("keepAliveInterval not within given limits!");
         }
 
-        sessionThread = new Thread(this, "SessionThread");
+        sessionThread = new Thread(this, "OH-binding-" + MilightBindingConstants.BINDING_ID + "-SessionThread");
     }
 
     /**

bundles/org.openhab.binding.milight/src/main/java/org/openhab/binding/milight/internal/protocol/QueuedSend.java

@@ -48,7 +48,7 @@ public class QueuedSend implements Runnable, Closeable {
      */
     public void start() {
         willbeclosed = false;
-        thread = new Thread(this);
+        thread = new Thread(this, "OH-binding-" + MilightBindingConstants.BINDING_ID + "-QueueSend");
         thread.start();
     }
 

bundles/org.openhab.binding.milight/src/main/java/org/openhab/binding/milight/internal/test/EmulatedV6Bridge.java

@@ -92,8 +92,8 @@ public class EmulatedV6Bridge {
             FAKE_MAC[2], FAKE_MAC[3], FAKE_MAC[4], FAKE_MAC[5], 1 };
 
     EmulatedV6Bridge() {
-        new Thread(this::runDiscovery).start();
-        new Thread(this::runBrigde).start();
+        new Thread(this::runDiscovery,"OH-binding-" + MilightBindingConstants.BINDING_ID + "-runDiscovery").start();
+        new Thread(this::runBridge,"OH-binding-" + MilightBindingConstants.BINDING_ID + "-runBridge").start();
     }
 
     private void replaceWithMac(byte[] data, int offset) {
@@ -144,7 +144,7 @@ public void runDiscovery() {
         }
     }
 
-    public void runBrigde() {
+    public void runBridge() {
         try {
             byte[] a = new byte[0];
             DatagramPacket sPacket = new DatagramPacket(a, a.length);

bundles/org.openhab.binding.pentair/src/main/java/org/openhab/binding/pentair/internal/handler/PentairBaseBridgeHandler.java

@@ -203,7 +203,7 @@ private void baseConnect() {
             return;
         }
 
-        Thread parserThread = new Thread(parser, "OH-pentair-" + this.getThing().getUID() + "-parser");
+        Thread parserThread = new Thread(parser, "OH-binding-" + this.getThing().getUID() + "-parser");
         this.parserThread = parserThread;
 
         parserThread.setDaemon(true);

bundles/org.openhab.binding.russound/src/main/java/org/openhab/binding/russound/internal/net/SocketChannelSession.java

@@ -24,6 +24,8 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicReference;
 
+import org.openhab.binding.lutron.internal.grxprg.SocketSession;
+import org.openhab.binding.russound.internal.RussoundBindingConstants;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -127,8 +129,10 @@ public void connect(int timeout) throws IOException {
 
         responses.clear();
 
-        dispatchingThread = new Thread(new Dispatcher());
-        responseThread = new Thread(new ResponseReader());
+        dispatchingThread = new Thread(new Dispatcher(),
+                "OH-binding-" + RussoundBindingConstants.BINDING_ID + "-dispatcher");
+        responseThread = new Thread(new ResponseReader(),
+                "OH-binding-" + RussoundBindingConstants.BINDING_ID + "-responseReader");
 
         dispatchingThread.start();
         responseThread.start();

bundles/org.openhab.binding.satel/src/main/java/org/openhab/binding/satel/internal/protocol/SatelModule.java

@@ -520,7 +520,7 @@ public void run() {
                     SatelModule.this.communicationLoop(CommunicationWatchdog.this);
                     logger.debug("Communication thread stopped");
                 }
-            });
+            }, "OH-binding-" + SatelBindingConstants.BINDING_ID + "-dispatcher");
             thread.start();
             this.thread = thread;
             // if module is not initialized yet, send version command