Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbquery] Fix Thing Action support for DSL rules #17784

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[dbquery] Fix Thing Action support for DSL rules #17784

merged 1 commit into from
Nov 22, 2024

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Nov 22, 2024 •
edited by lsiepel
Loading

Related to #17504

Edit: Also fixes support for old DSL-rules

@lolodomo
[dbquery] Fix thing action annotation
e467cab 
Related to openhab#17504

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo requested a review from lujop as a code owner November 22, 2024 09:25
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 22, 2024
@lolodomo lolodomo mentioned this pull request Nov 22, 2024
Closed
4 tasks
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Nov 22, 2024
@lsiepel lsiepel merged commit fd092a2 into openhab:main Nov 22, 2024
5 checks passed
@lolodomo lolodomo deleted the fix_actionoutput_dbquery branch November 22, 2024 20:45
@jlaur jlaur added this to the 4.3 milestone Nov 22, 2024
@jlaur
Copy link
Contributor

jlaur commented Nov 22, 2024 •
edited
Loading

@lolodomo, @lsiepel - maybe we should rename the PR title to something like "Fix Thing Action support for DSL rules"? The other recently merged Thing annotation PR's don't have a label and won't be mentioned in the release notes, so IMHO we should either repurpose the title or remove the bug label.

@lsiepel lsiepel changed the title [dbquery] Fix thing action annotation [dbquery] Fix Thing Action support for DSL rules Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel left review comments

@lujop lujop Awaiting requested review from lujop lujop is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @jlaur @lsiepel