-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[verisure] Fix broken cloud authentication #17761
Conversation
Signed-off-by: Jan Gustafsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a added some quick feedback from first read-through.
...ing.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureHandlerFactory.java
Outdated
Show resolved
Hide resolved
...ab.binding.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureSession.java
Outdated
Show resolved
Hide resolved
...ab.binding.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureSession.java
Outdated
Show resolved
Hide resolved
...ab.binding.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureSession.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Gustafsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment with a few clarifications needed, otherwise LGTM.
...ab.binding.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureSession.java
Outdated
Show resolved
Hide resolved
...ab.binding.verisure/src/main/java/org/openhab/binding/verisure/internal/VerisureSession.java
Outdated
Show resolved
Hide resolved
@jannegpriv - I assume this issue prevents the binding from working at all, is that correct? |
Correct.
BR,
/Janne
tors 21 nov. 2024 kl. 17:42 skrev Jacob Laursen ***@***.***>:
… @jannegpriv <https://github.com/jannegpriv> - I assume this issue
prevents the binding from working at all, is that correct?
—
Reply to this email directly, view it on GitHub
<#17761 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD42ZYMM7HJ77TK237DWVRL2BYEQZAVCNFSM6AAAAABR6LJFPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRG42DGMBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix Verisure bridge cannot login (#17730) Signed-off-by: Jan Gustafsson <[email protected]>
Fix for Verisure bridge cannot login (#17730).
Re-wrote logic for login and handling of tokens.