Simplify DateTimeType handling
#17725
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
work in progress
jlaur
force-pushed
the
datetimetype-instant
branch
3 times, most recently
from
86ec8a2
to
d397b88
Compare
jlaur
force-pushed
the
datetimetype-instant
branch
8 times, most recently
from
2a79387
to
9940eec
Compare
jlaur
force-pushed
the
datetimetype-instant
branch
11 times, most recently
from
315137b
to
b3209c5
Compare
jlaur
force-pushed
the
datetimetype-instant
branch
2 times, most recently
from
e34093e
to
fdf7df0
Compare
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
datetimetype-instant
branch
2 times, most recently
from
d7d358e
to
adc97e5
Compare
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
datetimetype-instant
branch
from
adc97e5
to
d27db29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup only and does not change functionality when openhab/openhab-core#3583 has first been merged. The core PR discards time-zone from
DateTimeType, thus binding code can be simplified:ZonedDateTimeusing either time-zone fromTimeZoneProviderorZoneId.systemDefault()have been simplified to useInstant. In some cases this entirely eliminated the need forTimeZoneProvider, which has then been removed.toZoneandtoLocaleZonehave been removed.getZonedDateTimehave been removed. In cases where time-zone is needed,getInstant().atZone(ZoneId.systemDefault())is now explicitly called.Related to openhab/openhab-core#3583