Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automower] Implementation of complete automower API #17545

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Oct 12, 2024

[automower] Implementation of complete automower API

References:

Current Status / TODOs:

  1. Implementation of Read Channels:
    1.1 DONE
  2. Implementation of Write Channels:
    2.1 DONE /mowers/{id}/actions
    2.2 DONE /mowers/{id}/calendar
    2.3 DONE /mowers/{id}/errors/confirm
    2.4 DONE /mowers/{id}/settings
    2.5 DONE /mowers/{id}/stayOutZones/{stayOutId}
    2.6 DONE /mowers/{id}/workAreas/{workAreaId}
    2.7 DONE /mowers/{id}/workAreas/{workAreaId}/calendar
  3. Dynamic Channels and Channel Groups
    3.1 postponed
  4. Readme
    4.1 DONE
  5. New Cut vs Search ratio channel:
    5.1 DONE
  6. openHAB actions
    6.1 DONE
  7. Better meta data (e.g. unit and state description) on channels
    7.1 DONE
  8. Fix [automower] planner-next-start does not reflect the correct offset to GMT #17147
    8.1 DONE
  9. i18n update
    9.1 DONE
  10. upgrade instructions
    10.1 DONE

@MikeTheTux MikeTheTux marked this pull request as draft October 12, 2024 06:44
@MikeTheTux MikeTheTux changed the title [automower] Implementation of complete automower API [automower] Implementation of complete automower API [WIP] Oct 12, 2024
@MikeTheTux MikeTheTux added the work in progress A PR that is not yet ready to be merged label Oct 12, 2024
@MikeTheTux
Copy link
Contributor Author

@lsiepel, do you have a good example how to implement dynamic Channels and Channel Groups? Esp. dynamic Channel Groups seems to be tricky.

@MikeTheTux MikeTheTux added the enhancement An enhancement or new feature for an existing add-on label Oct 12, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Oct 12, 2024

@lsiepel, do you have a good example how to implement dynamic Channels and Channel Groups? Esp. dynamic Channel Groups seems to be tricky.

Interesting combination, don't have an example straight out of my head, let me check.

Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
workaround for ambiguous timezone handling of automower api

Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
added actions

Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux
Copy link
Contributor Author

Except from dynamic channels and channel groups (which is an usability improvement only), I would consider the main part of the implementation is done.
I think it would be great that we bring this complex PR into the December release (which should be the winter break of the mower in the northern hemisphere). Therefore I would like to request an initial review round.

Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux removed the work in progress A PR that is not yet ready to be merged label Nov 9, 2024
@MikeTheTux MikeTheTux changed the title [automower] Implementation of complete automower API [WIP] [automower] Implementation of complete automower API Nov 9, 2024
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux marked this pull request as ready for review November 14, 2024 18:07
@MikeTheTux
Copy link
Contributor Author

Implementation done - ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automower] planner-next-start does not reflect the correct offset to GMT
2 participants