Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[huesync] Hue Play HDMI Sync Box Binding - Initial contribution #16516

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open

[huesync] Hue Play HDMI Sync Box Binding - Initial contribution #16516

wants to merge 128 commits into from
+2,937 −0

Commits on Sep 29, 2024

  1. ☠️ Binding skeleton created for org.openhab.binding.huesync 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    418eb57 View commit details
    Browse the repository at this point in the history

  2. 🔃 Version Sync - we'll use 4.1.x for development ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1fbd2b6 View commit details
    Browse the repository at this point in the history

  3. 💳 updated credits in headers (initial code by Marco Kawon) 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    053f7eb View commit details
    Browse the repository at this point in the history

  4. ✏️ class & filenames updated to be consistent with other bindings 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    656008d View commit details
    Browse the repository at this point in the history

  5. 🔎 skeleton mDNS discovery implemented 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    d5d9b62 View commit details
    Browse the repository at this point in the history

  6. 🔎 mDNS device discovery - use API to get device information (wip 🔨) 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cc6d39a View commit details
    Browse the repository at this point in the history

  7. 🔐 preparation(s) to support SSL (wip), create ThingUID for discovered… 

    … device

Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a16c04c View commit details
    Browse the repository at this point in the history

  8. 🏭 Inbox/Thing Factory (wip) 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    beadc45 View commit details
    Browse the repository at this point in the history

  9. 🔎 device discovery improvements (wip) 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c72c5e3 View commit details
    Browse the repository at this point in the history

  10. 💬 Basic JSON de-serialization added to Thing-Handler to get device in… 

    …formation

Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7b4fffc View commit details
    Browse the repository at this point in the history

  11. 🔐 SSL Handshake & 🔎 Discovery working - 👍 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    294deb3 View commit details
    Browse the repository at this point in the history

  12. 🔓 Registration (acquire API token) - wip 🔧 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    eb06000 View commit details
    Browse the repository at this point in the history

  13. 🔧 Prototype to use resource strings for loggger, exceptions & UI ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4b66cda View commit details
    Browse the repository at this point in the history

  14. 🔓 Registration (acquire API token) - wip 🔧 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2d3cfc9 View commit details
    Browse the repository at this point in the history

  15. 🔓 Registration (acquire API token) 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    871e286 View commit details
    Browse the repository at this point in the history

  16. ⏫ pom version change to 4.2 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    267fc75 View commit details
    Browse the repository at this point in the history

  17. 📜 linter fix ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f18346f View commit details
    Browse the repository at this point in the history

  18. 📜 linter fix 

    Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    142f8f9 View commit details
    Browse the repository at this point in the history

  19. 📜 ... temporary refactoring/removal of log message consistency mechan… 

    …ism to avoid linter error 🤔

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    57b8ca7 View commit details
    Browse the repository at this point in the history

  20. 📦 Device information DTO 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2d981b5 View commit details
    Browse the repository at this point in the history

  21. 👤 Added myself as owner of the huesync binding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9f64cc9 View commit details
    Browse the repository at this point in the history

  22. 🔧 refactoring to simplify API connection 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9b66703 View commit details
    Browse the repository at this point in the history

  23. feat(unregistration): 👋 Device unregistration 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    6e840ac View commit details
    Browse the repository at this point in the history

  24. fix(linter): 🔎 Format should be constant. Use placeholder to reduce t… 

    …he needless cost of parameter construction.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    de14fc1 View commit details
    Browse the repository at this point in the history

  25. fix(linter): 🔎 Format should be constant. Use placeholder to reduce t… 

    …he needless cost of parameter construction.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    70bb80b View commit details
    Browse the repository at this point in the history

  26. refactor: 📜 code moved and group areas added to improve overview 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    36b8d0c View commit details
    Browse the repository at this point in the history

  27. refactor: 📜 refactoring to simplify maintentance and pending implemen… 

    …tation tasks

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    6f9b46a View commit details
    Browse the repository at this point in the history

  28. fix(linter): 🔎 linter performance check fixed 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    428b3e3 View commit details
    Browse the repository at this point in the history

  29. feat(infrastructure): 🔌 check online/offline state (poll) - wip ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7f3a4e5 View commit details
    Browse the repository at this point in the history

  30. refactor(code review): 🔎 improved null handling based on code review 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a76e439 View commit details
    Browse the repository at this point in the history

  31. refactor(code review): 🔎 improved null handling based on code review 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    072bee7 View commit details
    Browse the repository at this point in the history

  32. refactor(code review): 🔎 improved null handling based on code review 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cb0c86c View commit details
    Browse the repository at this point in the history

  33. refactor(code review): 🔎 improved null handling based on code review 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4dd836e View commit details
    Browse the repository at this point in the history

  34. refactor(code review): 🔎 code split (single response) and better enca… 

    …psulation to simplify null handling and annotation

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4e1a812 View commit details
    Browse the repository at this point in the history

  35. refactor(code review): 🔎 improved null handling based on code review … 

    …... 🤔 - wip?

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5e60e97 View commit details
    Browse the repository at this point in the history

  36. refactor(code review): 🔎 improved null handling based on code review 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    048ce86 View commit details
    Browse the repository at this point in the history

  37. refactor(connection): 📜 Simplified authentication mechanism 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0ce8d19 View commit details
    Browse the repository at this point in the history

  38. refactor(communication): 📜 improved error handling and manual configu… 

    …ration (wip)

- 💣 preparation for connection exceptions
- 📜 preparation for channel .xml's

BREAKING CHANGE:

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    dbd0bcc View commit details
    Browse the repository at this point in the history

  39. feat(channel): 🔧 firmware channel group added 

    - current firmware (read only)
- available/latest firmware (read only)

📜 minor improvements and refactoring ... (wip)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    024b8f6 View commit details
    Browse the repository at this point in the history

  40. fix(channel): 🔃 keep properties and firmware channel information in sync 

    - keep firmware property and channel in sync
- README.md updated

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    3399194 View commit details
    Browse the repository at this point in the history

  41. feat(dto): 📺 HDMI Status DTO & Get API implemented 

    📜 includes some refactoring (rename of classes and device status callback type)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4c72662 View commit details
    Browse the repository at this point in the history

  42. feat(channel): Some HDMI input and ouput channels added (read only) -… 

    … 🔧 wip

🧹 Additional code clean up and refactorings to improve maintainability  (⚙️ including refactoring of background job handling)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f7a6d91 View commit details
    Browse the repository at this point in the history

  43. feat(channel): Additional channel connection-statusadded 

    📜 includes also documentation updates in README.md

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    520713d View commit details
    Browse the repository at this point in the history

  44. feat(channel): ➕ Additional channel connection-lastSyncMode added 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a95d401 View commit details
    Browse the repository at this point in the history

  45. refactor(dto class renamed): 📜 Dto classes renamed to include the nat… 

    …ure of the class in the name (dto)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7ec2c02 View commit details
    Browse the repository at this point in the history

  46. feat(channel): ➕ "execution" API channel group implementation started… 

    … (read only)

- "Hue Sync operation mode" added (🔧 wip)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    adf46e7 View commit details
    Browse the repository at this point in the history

  47. chore(documentation): 📜 new "remote control" group added to readme 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    87eae1f View commit details
    Browse the repository at this point in the history

  48. feat(channel): ➕ Infrastructure to handle command execution (🔧 wip) 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0cf1991 View commit details
    Browse the repository at this point in the history

  49. chore(documentation): 📜 readme updated: bug fixes & "mode" channel added 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    73b3ea6 View commit details
    Browse the repository at this point in the history

  50. chore(documentation): 📜 readme - item configuration header level changed 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5adecd6 View commit details
    Browse the repository at this point in the history

  51. fix(channel): 🐞Command executors are not global, but are defined per … 

    …device.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0744fcd View commit details
    Browse the repository at this point in the history

  52. feat(channel): ➕ write support for "mode" channel added 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    77e1c10 View commit details
    Browse the repository at this point in the history

  53. chore(documentation): 📜 readme - "mode" chanel is now R/W 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4c18512 View commit details
    Browse the repository at this point in the history

  54. chore(documentation): 🐞 bugfix in readme ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1088264 View commit details
    Browse the repository at this point in the history

  55. fix(connection): 🐞 bugfix to improve handling of invalid API token 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    78a9c79 View commit details
    Browse the repository at this point in the history

  56. fix(communication): 🐞 bugfix: de-serialization is more tolerant if we… 

    … receive more information than expected.

- dummy channel type "unknown" removed from "mode" command
- connection configuration update moved to "start task" (Note: might be problematic if the IP or port configuration changes - not sure if we support this ...)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e6e72d0 View commit details
    Browse the repository at this point in the history

  57. feat(channel): ➕ "syncActive" ON/OFF switch added to thing 

     - 💄 minor code cosmetics and refactorings

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    8274825 View commit details
    Browse the repository at this point in the history

  58. build(vscode): 🔧 configuration files added for IDE ... [wip] 

    Configuration files for Visual Studio Code IDE added to simplify contributions to the binding in the future. This is a proposal and might not be merged depending on feedback. I'll also add docker files and readme to provide a lean and fast development experience.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a885cc8 View commit details
    Browse the repository at this point in the history

  59. feat(channel): ➕ channel to select HDMI source added 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    91daa6a View commit details
    Browse the repository at this point in the history

  60. Update bundles/org.openhab.binding.huesync/pom.xml 

    Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @wborn
    pgfeller and wborn committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c760b56 View commit details
    Browse the repository at this point in the history

  61. style(format): code format fixes (whitespace) 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b22683f View commit details
    Browse the repository at this point in the history

  62. fix(localization): 🐛Suppress "Null type mismatch" linter error - the … 

    …`Optional`class should handle this correctly.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    65915aa View commit details
    Browse the repository at this point in the history

  63. style(format): code format fixes (whitespace) 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a46fecb View commit details
    Browse the repository at this point in the history

  64. refactor(i18n): Different handling of resource key resolution (linter… 

    … error)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    be1087f View commit details
    Browse the repository at this point in the history

  65. refactor(i18n): Different handling of resource key resolution (linter… 

    … error)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    df5b459 View commit details
    Browse the repository at this point in the history

  66. build(vscode): ⚙️ Small improvements in the utility build script(s) 

    ℹ️ `.vscode` directory might not be part of the merge (depending on review comments) - but we keep it as proposal, or will move it to the docs or forum later 📜

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1116696 View commit details
    Browse the repository at this point in the history

  67. docs(channel): 📜 Use of "Material Design Icons" to visualize category. 

    Use of "Material Design Icons" (mdi) in channel definitions, to beef up the visual representation in the UI.

Preparation for new feature: Brightness

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    353956c View commit details
    Browse the repository at this point in the history

  68. feat(channel): ➕ Add support to adjust brightness 

    📜 Refactoring: Simplification of command execution infrastructure.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    61e88ec View commit details
    Browse the repository at this point in the history

  69. fix(channel): 🐛 default execution handler fixed 

    ➕ Add support for HDMI active channel

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e69fd3f View commit details
    Browse the repository at this point in the history

  70. docs(readme): 🧹 Prepare for 1st official code review round of the PR 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a201ee5 View commit details
    Browse the repository at this point in the history

  71. fix(channel): 🐛 PUT command payload problem solved for StringType c… 

    …hannel(s)

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    27a3e97 View commit details
    Browse the repository at this point in the history

  72. chore(project): 🔎 Resolve code review findings 

    Removed unnecessary files from project/unwanted files from project.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    90476fb View commit details
    Browse the repository at this point in the history

  73. chore(project): 🔎 Resolve code review findings 

    I do not use the root folder for development, but only the binding project folder (to speed up things on my machine). Without this change the .vscode folder used in`openhab-addons/bundles/org.openhab.binding.huesync` will not be ignored by git.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b815915 View commit details
    Browse the repository at this point in the history

  74. chore(project): 🔎 Resolve code review findings 

    Remove 'dto' from file and class names in 'dto'  namespace - as this information is redundant.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f0b72ac View commit details
    Browse the repository at this point in the history

  75. Update bundles/org.openhab.binding.huesync/src/main/feature/feature.xml 

    Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4cf94bd View commit details
    Browse the repository at this point in the history

  76. Update bundles/org.openhab.binding.huesync/src/main/resources/OH-INF/… 

    …thing/channel-types.xml

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ea8c492 View commit details
    Browse the repository at this point in the history

  77. Update bundles/org.openhab.binding.huesync/src/main/resources/OH-INF/… 

    …thing/channel-types.xml

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1b7dcf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Renamed artifactId in pom.xml according to code review comment.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    2866bd3 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.huesync/src/main/feature/feature.xml 

    Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d9f1a97 View commit details
    Browse the repository at this point in the history

  3. chore(project): 🔎 Resolve code review findings 

    THING_TYPE_ID updated according to review comment

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    45babc6 View commit details
    Browse the repository at this point in the history

  4. chore(project): 🔎 Resolve code review findings 

    - THING_TYPE_ID updated according to review comment (fixed typo)
- label suggestions applied to channel-types

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    b64be6e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Default values for channel-type **connection-type** added.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    19b4efc View commit details
    Browse the repository at this point in the history

  2. chore(project): 🔎 Resolve code review findings 

    Default values for channel-type **connection-type** added.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9301a43 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8bc8285 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3917018 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. chore(project): 🔎 Resolve code review findings, updated exception han… 

    …dling in case of invalid token.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    13eedb0 View commit details
    Browse the repository at this point in the history

  2. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b466d08 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1fc9dfa View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    4eab015 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3baf75d View commit details
    Browse the repository at this point in the history

  2. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a7b4612 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3b79781 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/handler/tasks/HueSyncRegistrationTask.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ce62b8a View commit details
    Browse the repository at this point in the history

  3. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/handler/HueSyncHandler.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4b40f35 View commit details
    Browse the repository at this point in the history

  4. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3f95878 View commit details
    Browse the repository at this point in the history

  5. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e67bb3a View commit details
    Browse the repository at this point in the history

  6. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncDeviceConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1f04cd6 View commit details
    Browse the repository at this point in the history

  7. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/handler/tasks/HueSyncUpdateTask.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ce69d02 View commit details
    Browse the repository at this point in the history

  8. chore(project): 🔎 Resolve code review findings 

    Update names to follow coding convention.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    10c513c View commit details
    Browse the repository at this point in the history

  9. chore(project): 🔎 Resolve code review findings 

    Obsolete image file removed.

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2be093c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    88ca719 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncDeviceConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6108d4e View commit details
    Browse the repository at this point in the history

  3. chore(project): 🔎 Resolve code review findings 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    59c8c5c View commit details
    Browse the repository at this point in the history

  4. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    356dad6 View commit details
    Browse the repository at this point in the history

  5. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncDeviceConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    34c114a View commit details
    Browse the repository at this point in the history

  6. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncDeviceConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ee9170a View commit details
    Browse the repository at this point in the history

  7. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/discovery/HueSyncDiscoveryParticipant.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5d2a788 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. 🔧 post merge clean up (fix) 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2ad011b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. chore(project): 🔎 Resolve code review findings (README.md) 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6101c15 View commit details
    Browse the repository at this point in the history

  2. refactor(lint): 🔎 Apply static code analysis improvements/cosmetics 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    87412db View commit details
    Browse the repository at this point in the history

  3. refactor(project): 🔎 Resolve code review and code analysis finding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    95cfce5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. refactor(project): 🔎 Resolve code review and code analysis finding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    1616f91 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. refactor(logger): 🧹 Obsolete custom log factory removed 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    f6bf2e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. docs(readme): 🔎 Address review findings and complete readme 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8395105 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.huesync/README.md 

    Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    818f6f4 View commit details
    Browse the repository at this point in the history

  3. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/handler/tasks/HueSyncUpdateTask.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4befab5 View commit details
    Browse the repository at this point in the history

  4. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/handler/tasks/HueSyncRegistrationTask.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7a788af View commit details
    Browse the repository at this point in the history

  5. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/discovery/HueSyncDiscoveryParticipant.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1293f64 View commit details
    Browse the repository at this point in the history

  6. Update bundles/org.openhab.binding.huesync/src/main/java/org/openhab/… 

    …binding/huesync/internal/connection/HueSyncDeviceConnection.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller @lsiepel
    pgfeller and lsiepel authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    dc699a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. refactor(project): 🔎 Resolve code review finding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d49584d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. docs(readme): 🔎 Resolve code review finding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    546c703 View commit details
    Browse the repository at this point in the history

  2. refactor(project): 🔎 Resolve code review finding 

    Seems to be a false positive reported by the IDE - seems to build ok - let's check with CI ...

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    aeb8f76 View commit details
    Browse the repository at this point in the history

  3. refactor(project): 🔎 Resolve code review finding 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    649d765 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. refactor(project): 🔎 Resolve code review finding 

    remove  @SuppressWarnings("null")

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5633ef2 View commit details
    Browse the repository at this point in the history

  2. refactor(project): 🔎 Resolve static code analysis - HdmiChannels.java 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    dd30809 View commit details
    Browse the repository at this point in the history

  3. refactor(project): 🔎 Resolve static code analysis - HueSyncLocalizer.… 

    …java

Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b1781ed View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. refactor(lint): Static code analysis ... 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e842959 View commit details
    Browse the repository at this point in the history

  2. refactor(lint): 🧹 static code analysis - HueSyncConnection 

    Signed-off-by: Patrik Gfeller <[email protected]>
    @pgfeller
    pgfeller committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d8d519b View commit details
    Browse the repository at this point in the history