[rainsoft] [WIP] RainSoft Binding initial contribution #14923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
jlaur
added
the
new binding
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
wborn
reviewed
Jul 24, 2023
Signed-off-by: Ben Rosenblum <[email protected]>
|
This is updated for 4.1.0 |
wborn
reviewed
Dec 23, 2023
Signed-off-by: Ben Rosenblum <[email protected]>
lsiepel
reviewed
Dec 29, 2023
There was a problem hiding this comment.
As this is largely based on the ring binding, several comments i just left about the documentation (readme, xml, i18n) apply here too. Let me know when you are ready for a first pass. I'm fine if that is still in a draft state if that helps you to bring this forward.
There was a problem hiding this comment.
Thank you! This is absolutely based on the ring binding. I always assumed it would go through review first, I would pull all those changes in here, and then push this for review.
wborn
reviewed
Jul 9, 2024
Signed-off-by: Ben Rosenblum <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial contribution of the RainSoft binding. RainSoft produces water conditioning systems for homes. A few of the newer models support statistics about water usage. This binding is mostly read-only to gather data from RainSoft.
This is still a work in progress. Binding is based off of the code of the Ring binding.
Fixes #14739