feat: email validator #8
Conversation
Downgrade because current version breaks Markdown formatting with HTML tables
|
@qin-guan OK now it's just a simple |
| domain === whitelisted.domain || | ||
| (whitelisted.includeSubdomains && | ||
| domain.endsWith(`.${whitelisted.domain}`)), |
There was a problem hiding this comment.
very nitty: would
whitelisted.includeSubdomains ? domain.endsWith(`.${whitelisted.domain}`) : domain === whitelisted.domain
be somewhat more readable? @qin-guan thots?
There was a problem hiding this comment.
@spaceraccoon subtle difference in logic here: in the original, if includeSubdomains is true, an exact match of the domain is still allowed (instead of only .${whitelisted.domain})
There was a problem hiding this comment.
I think either is okay, just need to document down clearly what the expected / not expected behaviors are and maybe a comment in the code to clarify
There was a problem hiding this comment.
OK will clarify the documentation + add comment!
Co-authored-by: Eugene Lim <[email protected]>
Co-authored-by: Qin Guan <[email protected]>
Co-authored-by: Qin Guan <[email protected]>
Email validator that addresses the subdomain validation problem.