Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node path import #32

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: node path import #32

merged 3 commits into from
Nov 19, 2024

Conversation

zhongliang02
Copy link
Contributor

This PR addresses an issue with the path validator introduced in versions 1.2.3 to 1.2.7 of our package. The node:path import syntax, while explicitly pointing to a Node.js built-in module, is not supported by the Next.js webpack configuration, causing build failures in some projects.

Changes:

  • Removed node: prefix from fs and path import statements

Rationale:

  1. This change resolves build failures in Next.js projects
  2. Security concerns about package squatting are mitigated:

Impact:

  • Fixes breaking builds with Next.js
  • No security issues introduced by changing the import specifier

@zhongliang02 zhongliang02 requested a review from a team November 19, 2024 07:42
@zhongliang02 zhongliang02 merged commit 5c57c19 into develop Nov 19, 2024
5 checks passed
@zhongliang02 zhongliang02 deleted the fix/node-path-import branch November 21, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants