feat: simplify redirect url pattern #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's a common pattern across multiple codebases for handling redirect URLs:
Changes
This PR introduces three key improvements to our URL validation and redirection process:
RelUrlValidator
ClassSimplifies the creation of UrlValidator with sensible defaults
Usage:
new RelUrlValidator(origin: string | URL)
UrlValidator.parse(..., fallbackUrl: string | URL)
Adds a
fallbackUrl
parameterEliminates the need to use
callbackUrlSchema
parsePathname
methodIntroduces
UrlValidator.parsePathname(...)
that can be directly assigned towindow.location.pathname
Example usage