Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to fix npm publishing issue #25

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zhongliang02
Copy link
Contributor

package.json is not updated to correct version number so release action did not publish to npm.
this potentially causes a desync in the future between git tag versions and npm versions

furthermore, the previous pr did not have the correct format in the title so the changelog is incomplete

fix:

  1. revert the pr
  2. delete the release
  3. delete the tag
  4. merge the pr with the fixed package.json and re-release

Copy link

linear bot commented Nov 7, 2024

Issue reopened: SEC-98 Fix Dynamic Routes Bypass

@zhongliang02 zhongliang02 requested a review from a team November 7, 2024 03:01
Copy link

@spaceraccoon spaceraccoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zhongliang02 zhongliang02 merged commit 031f6a3 into develop Nov 7, 2024
5 checks passed
@zhongliang02 zhongliang02 deleted the revert-24-feat/fix-dynamic-routes-bypass branch November 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants