Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dns migration #2250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: dns migration #2250

wants to merge 1 commit into from

Conversation

KishenKumarrrrr
Copy link
Contributor

Problem

In this PR, I make changes required to migration postman.gov.sg to legacy.postman.gov.sg

@KishenKumarrrrr KishenKumarrrrr self-assigned this Mar 25, 2024
jwnicholas99
jwnicholas99 approved these changes Mar 31, 2024
View reviewed changes
Copy link

@jwnicholas99 jwnicholas99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think

@jia1
Copy link
Member

jia1 commented Apr 4, 2024

Would the following need to be updated too?

amplify.yml

  • export REACT_APP_IMG_SERVER_URL="https://postman.gov.sg/v1";
  • DASHBOARD_URL: ${{ github.ref == 'refs/heads/master' && 'https://postman.gov.sg' || 'https://staging.postman.gov.sg' }}

email-theme.mustache

  • Powered by <a href="https://postman.gov.sg">Postman</a>, the official communication tool trusted by government agencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnicholas99 jwnicholas99 jwnicholas99 approved these changes

@jia1 jia1 jia1 approved these changes

@tankevan tankevan tankevan approved these changes

Assignees

@KishenKumarrrrr KishenKumarrrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KishenKumarrrrr @jia1 @tankevan @jwnicholas99