-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-393: Variables: keys with . may be single key or nested path #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kevinkim-ogp
changed the title
fix: formsg var keys with . may be single key
PLU-Formatter: FormSG MyInfo Child Birth date in dd/MM/yyyy format
Dec 20, 2024
kevinkim-ogp
changed the title
PLU-Formatter: FormSG MyInfo Child Birth date in dd/MM/yyyy format
PLU-394: fix: FormSG MyInfo Child Birth date in dd/MM/yyyy format
Dec 20, 2024
kevinkim-ogp
changed the title
PLU-394: fix: FormSG MyInfo Child Birth date in dd/MM/yyyy format
PLU-393: Variables: keys with . may be single key or nested path
Dec 20, 2024
Datadog ReportBranch report: ✅ 0 Failed, 732 Passed, 0 Skipped, 2m 9.01s Total Time |
pregnantboy
force-pushed
the
fix/formsg/var-single-keys-with-dot
branch
from
December 23, 2024 09:03
15f8281
to
da9ac46
Compare
pregnantboy
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
New MyInfo Child fields from FormSG returns data with
.
as part of the key (e.g.,child.birthdate
).Libraries like
lodash.get
treat.
as a path separator for nested properties (e.g., accessingchild.birthdate
), leading to incorrect value retrieval or failure.What changed?
.
in keys with_
to avoid issues with obtaining values.How to test?
Why make this change?
The standard lodash.get function doesn't properly handle cases where object keys contain dots, leading to incorrect property access. This implementation provides more accurate property resolution.