Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-378: PREVAMP: Make rich text editor scrollable after certain height #830

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

kevinkim-ogp
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp commented Dec 19, 2024

Problem

Rich text editor has an infinite scroll, causing the variable suggestion box to go off-screen, making it difficult to select variables.

Solution

Set max-height property for the editor to ensure it scrolls after the max height.

Improvements:

  • RTE will be scrollable after the max height set.

Before & After Screenshots

BEFORE:
Screenshot 2024-12-19 at 2 24 08 PM
Screenshot 2024-12-19 at 2 24 41 PM

AFTER:
Screenshot 2024-12-19 at 2 25 25 PM

Tests

Note: this is a frontend change, no impact to backend functionality.

  • RTE content is updated and saved correctly
  • Variable suggestion box opens and selected variables are inserted into RTE correctly.

@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner December 19, 2024 06:28
Copy link

linear bot commented Dec 19, 2024

Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice

@pregnantboy pregnantboy merged commit d8fddbb into develop-v2 Dec 23, 2024
4 checks passed
@pregnantboy pregnantboy deleted the chore/rte-scrollable branch December 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants