Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-388: Postman Max 50 recipients #825

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

kevinkim-ogp
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp commented Dec 18, 2024

Problem

Postman limits each email to have a maximum of 50 recipients (including the primary recipient, CC recipients, and BCC recipients), but Plumber does not implement this check.

Solution

  • Add validation on the list of CC recipient emails

Improvements:

  • Add validation on the list of CC recipient emails and throw error before attempting to call the Postman API.

Before & After Screenshots

BEFORE:
NA

AFTER:
Screenshot 2024-12-18 at 5 30 00 PM

Tests

  • Existing emails can be sent correctly
  • Step error thrown when more than 49 recipients included in the CC field

@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner December 18, 2024 09:33
Copy link

linear bot commented Dec 18, 2024

@datadog-opengovsg
Copy link

Datadog Report

Branch report: chore/postman/max-50-recipients
Commit report: cd62329
Test service: plumber

✅ 0 Failed, 720 Passed, 0 Skipped, 2m 18.73s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.01%)

@kevinkim-ogp kevinkim-ogp changed the title PLU-338: Postman Max 50 recipients PLU-388: Postman Max 50 recipients Dec 18, 2024
Copy link

linear bot commented Dec 18, 2024

Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tested that it works nice thks

@kevinkim-ogp kevinkim-ogp merged commit 4d96b4a into develop-v2 Dec 19, 2024
4 checks passed
@kevinkim-ogp kevinkim-ogp deleted the chore/postman/max-50-recipients branch December 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants