Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLU-372: [UI-Prevamp] add delete step confirmation #824

Merged
merged 1 commit into from
Dec 19, 2024
Merged

PLU-372: [UI-Prevamp] add delete step confirmation #824

merged 1 commit into from
Dec 19, 2024

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Dec 18, 2024 •
edited
Loading

Problem

No confirmation before deleting a step from a pipe...

Solution

Reuse the AlertDialog and add it to the delete icon

Tests

  • Can delete step with the modal
  • Can cancel the deleting of step

@m0nggh m0nggh requested a review from a team as a code owner December 18, 2024 02:15
@linear Linear
Copy link

linear bot commented Dec 18, 2024

PLU-372 PREVAMP: Delete Step Confirmation

kevinkim-ogp
kevinkim-ogp approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and alert works! 💪

@m0nggh m0nggh merged commit 0d63f5e into develop-v2 Dec 19, 2024
4 checks passed
@m0nggh m0nggh deleted the chore/ui-revamp/delete-step-confirmation branch December 19, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkim-ogp kevinkim-ogp kevinkim-ogp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0nggh @kevinkim-ogp