PLU-370: [CUSTOM-API-FIX-2] do not overwrite Content-Type

[kevinkim-ogp]

TL;DR

Updated Custom API header handling to ensure:

• Content-Type = application/json, if not set by user
• Content-Type set in Connection step is not overwritten by Content-Type set in Custom Headers

What changed?

• Content-Type header is now set for all requests to application/json instead of Axios' default application/x-www-form-urlencoded

How to test?

1. Make a request to the custom API endpoint with no Content-Type set
2. Verify that the Content-Type header is present and is application/json
3. Create a Connection in Add connection step with a custom Content-Type
4. Verify that the Content-Type header is present and matches what was set
5. Add a different Content-Type to Custom header step
6. Verify that it does not overwrite the Content-Type set in the Add connection step

Why make this change?

The Content-Type header should be set consistently for all requests. The previous implementation only set it for requests with headers specified in the Connection step.

[kevinkim-ogp]

• PLU-370: [CUSTOM-API-FIX-2] do not overwrite Content-Type #823 👈 (View in Graphite)
• PLU-392: [CUSTOM-API-FIX-1] escape variable content #822
• develop-v2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[datadog-opengovsg]

Datadog Report

Branch report: fix/custom-api/do-not-overwrite-content-type
Commit report: 6992e34
Test service: plumber

✅ 0 Failed, 722 Passed, 0 Skipped, 2m 13.08s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.04%)

[linear]

PLU-392 custom api escape data input

[linear]

PLU-370 custom API: do not overwrite content-type header

[m0nggh]

lgtm tested that fix works thks

[pregnantboy]

Merge activity

• Dec 23, 2:50 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 23, 2:55 AM EST: Graphite couldn't merge this PR because it had conflicts with the trunk branch.
• Dec 24, 1:11 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 24, 1:12 AM EST: A user merged this pull request with Graphite.