M365 Excel - UX nit & logging improvement (#393)

opengovsg · Jan 12, 2024 · a1f5b19 · a1f5b19
1 parent af775f7
commit a1f5b19
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/backend/src/apps/m365-excel/common/interceptors/before-request.ts b/packages/backend/src/apps/m365-excel/common/interceptors/before-request.ts
@@ -19,6 +19,7 @@ import { consumeOrThrowLimiterWithLongestDelay } from '../rate-limiter'
 const usageTracker: TBeforeRequest = async function ($, requestConfig) {
   logger.info('Making request to MS Graph', {
     event: 'm365-ms-graph-request',
+    tenant: $.auth.data?.tenantKey as string,
     baseUrl: requestConfig.baseURL, // base URL is different for auth requests
     urlPath: requestConfig.url,
     flowId: $.flow?.id,

diff --git a/packages/backend/src/apps/m365-excel/index.ts b/packages/backend/src/apps/m365-excel/index.ts
@@ -7,7 +7,7 @@ import auth from './auth'
 import dynamicData from './dynamic-data'
 
 const app: IApp = {
-  name: 'M365 Excel',
+  name: 'M365 Excel (Pilot)',
   key: 'm365-excel',
   iconUrl: '{BASE_URL}/apps/m365-excel/assets/favicon.svg',
   authDocUrl: 'https://guide.plumber.gov.sg/user-guides/actions/m365-excel',

diff --git a/packages/backend/src/config/app-env-vars/m365.ts b/packages/backend/src/config/app-env-vars/m365.ts
@@ -77,7 +77,7 @@ function makeTenantInfo(opts: Partial<M365TenantInfo>): M365TenantInfo {
 
 export const m365TenantInfo = Object.freeze({
   'sg-govt': makeTenantInfo({
-    label: 'SG Govt',
+    label: 'SG Govt SharePoint',
     id: process.env.M365_SG_GOVT_TENANT_ID,
     sharePointSiteId: process.env.M365_SG_GOVT_SHAREPOINT_SITE_ID,
     clientId: process.env.M365_SG_GOVT_CLIENT_ID,
@@ -90,7 +90,7 @@ export const m365TenantInfo = Object.freeze({
   ...(appConfig.isDev
     ? {
         'govtech-staging': makeTenantInfo({
-          label: 'GovTech Staging',
+          label: 'GovTech Staging SharePoint',
           id: process.env.M365_GOVTECH_STAGING_TENANT_ID,
           sharePointSiteId: process.env.M365_GOVTECH_STAGING_SHAREPOINT_SITE_ID,
           clientId: process.env.M365_GOVTECH_STAGING_CLIENT_ID,
@@ -102,7 +102,7 @@ export const m365TenantInfo = Object.freeze({
           ),
         }),
         'local-dev': makeTenantInfo({
-          label: 'Local Development',
+          label: 'Local Development SharePoint',
           id: process.env.M365_LOCAL_DEV_TENANT_ID,
           sharePointSiteId: process.env.M365_LOCAL_DEV_SHAREPOINT_SITE_ID,
           clientId: process.env.M365_LOCAL_DEV_CLIENT_ID,