add small fixes

opengovsg · May 21, 2024 · 5433e42 · 5433e42
1 parent b758948
commit 5433e42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx b/packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
@@ -88,7 +88,7 @@ export default function Suggestions(props: SuggestionsProps) {
           textStyle="subhead-1"
           color="base.content.medium"
         >
-          Choose Data
+          Choose data
         </Text>
         <Divider borderColor="base.divider.medium" />
         {data.map((option, index) => (
@@ -118,11 +118,15 @@ export const SuggestionsPopper = (props: SuggestionsPopperProps) => {
 
   const offsetVerticalMargin = editorRef?.current?.offsetHeight ?? 0
 
+  if (!open) {
+    return null
+  }
+
   return (
     <Popover
-      isOpen={open}
+      isOpen
       initialFocusRef={editorRef}
-      offset={[0, offsetVerticalMargin]}
+      offset={[0, offsetVerticalMargin + 1]} // this is adjusted based on DS input
     >
       <PopoverTrigger>
         <div />

diff --git a/packages/frontend/src/components/TestSubstep/TestResult.tsx b/packages/frontend/src/components/TestSubstep/TestResult.tsx
@@ -122,9 +122,7 @@ export default function TestResult(props: TestResultsProps): JSX.Element {
           }
         </Text>
       </Infobox>
-      <Box maxH="25rem" overflowY="scroll" w="100%">
-        <VariablesList variables={stepsWithVariables[0].output} />
-      </Box>
+      <VariablesList variables={stepsWithVariables[0].output} />
     </Box>
   )
 }