Skip to content

Commit

Permalink
chore: update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ogp-weeloong committed Apr 18, 2024
1 parent f42936c commit 2946974
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ const handle429: ThrowingHandler = ($, error) => {
// https://learn.microsoft.com/en-us/graph/workbook-best-practice?tabs=http#reduce-throttling-errors
//
// Excel endpoints are uniquely identified by the `/workbook/` url segment.
// It's safe to directly check for this substring in the URL because '/'s are
// escaped if they're from user input.
//
// FIXME (ogp-weeloong): eval if we can remove this and just retry _all_ 429s
// once we get bullmq pro in.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export async function throttleStepsForPublishedPipes(
error: 'Reached M365 step limit',
// If we're rate limited, we're probably facing a spike of steps for that
// file, so spread out retries over a wider time period (2x) to reduce the
// size of the retry thundering herd.
// size of the retry thundering herd at any point in time.
delayInMs: P90_EXCEL_API_RTT_SECONDS * 1000 * 2,
})
}
Expand Down

0 comments on commit 2946974

Please sign in to comment.