Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isom-1646 - infocards and infocols should behave consistently when opens in a new link #954

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adriangohjw
Copy link
Contributor

Problem

Closes https://linear.app/ogp/issue/ISOM-1646/infocards-and-infocols-should-behave-consistently-when-something-opens

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

add check if it's external URL, and if so:

  1. rotate the icon if it is (couldn't find a corresponding diagonal arrow of similar styles)
  2. opens in new tab

Tests

Infocards

  1. Go to a page and add a Infocards component
  2. By default, the default endpoint is "https://www.google.com" so it should show right-up arrow
  3. Update the link of one of the cards to link to one of the internal page - it should show right arrow
  4. Save and publish, and check if the external link on the new site opens in a new url
image

Infocols

  1. Go to a page and add a Infocols component
  2. Add an external link for one of the cols - it should show right-up arrow
  3. Add an internal link for one of the cols - it should show right arrow
  4. Save and publish, and check if the external link on the new site opens in a new url
image

@adriangohjw adriangohjw added the bug Something isn't working label Dec 23, 2024
@adriangohjw adriangohjw self-assigned this Dec 23, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner December 23, 2024 03:16
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 23, 2024

Datadog Report

Branch report: adriangohjw/isom-1646-infocards-and-infocols-should-behave-consistently-when
Commit report: 0f5ff88
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 45.45s Total Time
➡️ Test Sessions change in coverage: 1 no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant