Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump @opengovsg/starter-kitty-validators to 1.2.10 #874

Merged
merged 6 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/studio/.storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { dirname, join } from "path"
import type { StorybookConfig } from "@storybook/nextjs"
import webpack from "webpack"

const config: StorybookConfig = {
stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
Expand All @@ -25,6 +26,16 @@ const config: StorybookConfig = {
disableTelemetry: true,
},

// https://github.com/vercel/next.js/issues/28774#issuecomment-1264555395
adriangohjw marked this conversation as resolved.
Show resolved Hide resolved
webpack: (config) => {
config.plugins?.push(
new webpack.NormalModuleReplacementPlugin(/^node:/, (resource) => {
resource.request = resource.request.replace(/^node:/, "")
}),
)
return config
},

env: (config) => ({
...config,
SKIP_ENV_VALIDATION: "true",
Expand Down
11 changes: 11 additions & 0 deletions apps/studio/next.config.mjs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import webpack from "webpack"

/**
* Run `build` or `dev` with `SKIP_ENV_VALIDATION` to skip env validation. This is especially useful
* for Docker builds.
Expand Down Expand Up @@ -65,6 +67,15 @@ const config = {
images: {
domains: [env.NEXT_PUBLIC_S3_ASSETS_DOMAIN_NAME ?? ""].filter((d) => d),
},
// https://github.com/vercel/next.js/issues/28774#issuecomment-1264555395
adriangohjw marked this conversation as resolved.
Show resolved Hide resolved
webpack: (config, options) => {
config.plugins.push(
new webpack.NormalModuleReplacementPlugin(/^node:/, (resource) => {
resource.request = resource.request.replace(/^node:/, "")
}),
)
return config
},
async headers() {
return [
{
Expand Down
2 changes: 1 addition & 1 deletion apps/studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@opengovsg/design-system-react": "^1.15.0",
"@opengovsg/isomer-components": "*",
"@opengovsg/sgid-client": "^2.2.0",
"@opengovsg/starter-kitty-validators": "^1.1.0",
"@opengovsg/starter-kitty-validators": "^1.2.7",
"@paralleldrive/cuid2": "^2.2.2",
"@prisma/client": "5.10.2",
"@sendgrid/mail": "^8.1.3",
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading