fix: schema #229
Merged
fix: schema #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to auto-increment
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seaerchin
commented
Jun 25, 2024
Comment on lines
+1
to
+6
| import { type IsomerSiteProps } from '@opengovsg/isomer-components' | ||
|
|
||
| export type Navbar = { items: IsomerSiteProps['navBarItems'] } | ||
|
|
||
| export interface FooterItem { | ||
| title: string |
There was a problem hiding this comment.
this is cherry-picked, downstream will refer correctly to IsomerSiteProps
dcshzj
approved these changes
Jun 26, 2024
|
|
||
| export type Navbar = { items: IsomerSiteProps['navBarItems'] } | ||
|
|
||
| export interface FooterItem { |
There was a problem hiding this comment.
nit: I suspect most of the types that we need on the CMS should be able to be derived from the exported props one way or another, so we might not need to re-define them here.
There was a problem hiding this comment.
exported for ease of use cos it's very tedious to type Isomer...['...'] every time ._.
remove / add type
| role: RoleType | ||
| } | ||
| export type Resource = { | ||
| id: string | ||
| id: GeneratedAlways<number> |
There was a problem hiding this comment.
Does this change affect the current tRPC schema, specifically the types?
There was a problem hiding this comment.
yes, they've been updated here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Original schema specifies
cuid, which is problematic on 2 frontsStringinstead ofGeneratedAlways<String>.Solution
GeneratedAlways