fix(MultiSelectProvider.tsx): double addition on mobile #817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This issue was first identified on ActiveSG where programme filters would be added twice when users performed the action on mobile. This issue does not exist outside mobile mode.
Refer to the following recording of the issue:
Screen.Recording.2024-12-11.at.11.54.22.AM.mov
Investigation
The root cause of the issue is still unclear.
@dextertanyj identified that
itemHandleClick
function indownshift
is only called once, eliminating the hypothesis that there was a bug in the package that led to the event being fired twice.@dextertanyj further identified that on mobile, two events
onClick
andonMouseMove
are fired at the same time (thus causing two state transitions). The current hypothesis is that this bug arises due to the way React handles both these transitions happening at (almost) the same time.This issue has been raised before, the conclusion is similar to ours: downshift-js/downshift#1534
Solution
Since the issue might be due to the internal implementation of React, we decided to instead just make the component idempotent. Thus, in
onSelectedItemsChange
, I use a set to remove duplicates.