Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for translated models #113

Merged
merged 18 commits into from
Nov 4, 2024
Merged

Add support for translated models #113

merged 18 commits into from
Nov 4, 2024

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Oct 25, 2024

Screenshot from 2024-10-28 21-48-15

Requires ili2db v5.2.0
References opengisch/QgisModelBaker#971

@gacarrillor gacarrillor marked this pull request as ready for review October 28, 2024 17:53
@gacarrillor
Copy link
Collaborator Author

Tests are failing because ili2db 5.2.0 is still not found as a release.

@signedav
Copy link
Member

claeis/ili2db@e437949 See this

As well the domain issue is solved in the next release of ili2db

@signedav
Copy link
Member

Can we merge that as soon we have 5.2 @gacarrillor ?

@gacarrillor
Copy link
Collaborator Author

Can we merge that as soon we have 5.2 @gacarrillor ?

Would be great indeed. I'll work on unit tests in the meantime.

@gacarrillor
Copy link
Collaborator Author

Tests will fail in GitHub until ili2db 5.2.0 is published.
They're passing on a local environment pointing to a ili2db 5.2.0 snapshot.

@signedav signedav closed this Nov 3, 2024
@signedav signedav reopened this Nov 3, 2024
@signedav
Copy link
Member

signedav commented Nov 4, 2024

@gacarrillor Several tests are failing with 5.2.0 I guess you only run your new test locally and not all the tests. Right? Otherwise there is something else not okay...

@signedav signedav merged commit 39a2ec7 into main Nov 4, 2024
5 checks passed
@signedav signedav deleted the translations_support branch November 4, 2024 13:34
@gacarrillor
Copy link
Collaborator Author

gacarrillor commented Nov 4, 2024

@gacarrillor Several tests are failing with 5.2.0 I guess you only run your new test locally and not all the tests. Right? Otherwise there is something else not okay...

Sorry about it, and thanks for fixing it @signedav!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants