Revert backwards-compat changes to devices API #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work to support multiple device types, the API for devices/nodes was changed; see #184, #186, #188 for details.
As we were not immediately able to change the middleware to support these changes, it was necessary to maintain backwards-compatibility with the old API format, by inlining the device details attributes and assuming that only compute devices were supported.
This reverts commit 6b8d3e9 to reintroduce the backwards-incompatible changes and allow support of multiple device types. We should merge this along with the relevant changes to the middleware (openflighthpc/concertim-openstack-service#37 plus two further PRs to come).