Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add content tag serialization/deserialization [FC-0049] #385

Conversation

rpenido
Copy link

@rpenido rpenido commented Feb 29, 2024

Description

This PR adds support to serialize/deserialize tag info from the block XML, adding it to the new xml_attributes property. This is used to allow pasting DragAndDrop components with their applied tags.

More Information

Testing instructions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 29, 2024

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

1 similar comment
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@rpenido rpenido changed the title feat: add content tag serialization/deserialization feat: add content tag serialization/deserialization [FC-0049] Feb 29, 2024
@rpenido rpenido marked this pull request as ready for review February 29, 2024 20:20
@rpenido rpenido requested a review from pomegranited February 29, 2024 20:20
@rpenido
Copy link
Author

rpenido commented Feb 29, 2024

Updating edx-platform with this version caused an error in a test. I will check it tomorrow.

@rpenido rpenido marked this pull request as draft February 29, 2024 21:57
@pomegranited
Copy link
Contributor

Shouldn't have to do this.. cf openedx/edx-platform#34270 (comment)

@openedx-webhooks
Copy link

@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants