-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate paragon-theme.json during npm run build with themeUrls #2333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2333 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 214 214
Lines 3534 3534
Branches 860 860
=======================================
Hits 3217 3217
Misses 309 309
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a minor nit of renaming some of the variables from ParagonConfig
to ParagonThemingConfig
but no big deal 👍🏽
🎉 This PR is included in version 21.0.0-alpha.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…openedx#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
…openedx#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
…#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
…#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
…#2333) * feat: generate paragon.config.json during npm run build with themeUrls * fix: rename to paragon-theme.json * chore: rename paragonConfig
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Generates a
paragon-theme.json
file indist
output directory containing relative paths to the compiled core and theme variant CSS paths:The
paragon.config.json
file will be parsed by@edx/frontend-build
to avoid needing to hardcodecore.min.css
orlight.min.css
into its code explicitly, rather relying on the paths provided by Paragon itself.Related PR: openedx/frontend-build#365
Deploy Preview
N/A
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist