Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assume a closed pr with no osc label is internal #276 #284

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Dec 5, 2023

This lets us close ex-edXers' pull requests without accidentally labelling them and adding them to projects.

This changes existing behavior: previously the bot was written to be able to first encounter PRs in their closed state. This change assumes all pull requests have been processed first when they are opened.

This PR includes #283, you can review them together or separately.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ee0182) 90.04% compared to head (15e0f1b) 89.76%.
Report is 3 commits behind head on master.

Files Patch % Lines
openedx_webhooks/tasks/pr_tracking.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   90.04%   89.76%   -0.29%     
==========================================
  Files          38       38              
  Lines        2853     2882      +29     
  Branches      398      397       -1     
==========================================
+ Hits         2569     2587      +18     
- Misses        259      268       +9     
- Partials       25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nedbat nedbat changed the title Nedbat/exedx 276 feat: assume a closed pr with no osc label is internal #276 Dec 5, 2023
@nedbat nedbat requested a review from feanil December 5, 2023 23:43
@nedbat nedbat marked this pull request as ready for review December 5, 2023 23:47
@nedbat nedbat merged commit 3f05749 into master Dec 7, 2023
5 of 6 checks passed
@nedbat nedbat deleted the nedbat/exedx-276 branch December 7, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants