-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn Django Admin users editing Collections [FC-0062] #233
Warn Django Admin users editing Collections [FC-0062] #233
Conversation
so users know to use Studio Django Admin instead of the LMS.
since we can't show the warning there
Thanks for the pull request, @pomegranited! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited Looks good 👍
- I tested this: I followed the testing instructions and verify the alert message
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
- Includes documentation
- Includes fixtures that create objects required for manual testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I tested this: Verified alert and collection soft-delete events
- I read through the code
- I checked for accessibility issues
- Includes documentation
Description
#229 added Django Admin screens for Collections, but testing revealed issues if Collections are edited in the LMS, due to missed signal handlers in the Studio Search app.
This PR adds warnings shown when editing a Collection, to encourage users to use the Studio Django Admin instead of the LMS. Also removes the configuration that allowed editing Collections from the Django Admin list view (so the warnings on the edit screen will be seen), and improves the "help" text for the "enabled" checkbox.
Supporting information
Related to: openedx/modular-learning#231
Private-ref: FAL-3809
Testing instructions
python manage.py shell
):python manage.py runserver
), and ensure you can:Deadline
ASAP